fix(cloudfront): EdgeFunction fails with newStyleStackSynthesis #12356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The EdgeFunction construct copied some patterns from CodePipelines to enable cross-environment interaction. One key difference is that for Lambda@Edge, CDK assets are created in the cross-environment support stack. This isn't supported by the BootstraplessSynthesizer, so this custom logic (copied from CodePipelines) needs to be removed. The EdgeFunction support stack will now use whatever synthesizer is default for the current stack. fixes #12172
njlynch
force-pushed
the
njlynch/edge-synthesis-fix
branch
from
b63172f
to
cf33ab4
Compare
rix0rrr
approved these changes
Jan 5, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
EdgeFunctionconstruct copied some patterns from CodePipelines to enablecross-environment interaction. One key difference is that for Lambda@Edge,
CDK assets are created in the cross-environment support stack. This isn't
supported by the BootstraplessSynthesizer, so this custom logic (copied from
CodePipelines) needs to be removed.
The EdgeFunction support stack will now use whatever synthesizer is default for
the current stack.
fixes #12172
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license