Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cloudfront): EdgeFunction fails with newStyleStackSynthesis #12356

Merged
merged 3 commits into from
Jan 5, 2021
Merged

fix(cloudfront): EdgeFunction fails with newStyleStackSynthesis #12356

merged 3 commits into from
Jan 5, 2021

Commits on Jan 5, 2021

  1. fix(cloudfront): EdgeFunction fails with newStyleStackSynthesis 

    The EdgeFunction construct copied some patterns from CodePipelines to enable
cross-environment interaction. One key difference is that for Lambda@Edge,
CDK assets are created in the cross-environment support stack. This isn't
supported by the BootstraplessSynthesizer, so this custom logic (copied from
CodePipelines) needs to be removed.

The EdgeFunction support stack will now use whatever synthesizer is default for
the current stack.

fixes #12172
    @njlynch
    njlynch committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    cf33ab4 View commit details
    Browse the repository at this point in the history

  2. Boo! 

    Fixing typo.

Co-authored-by: Rico Huijbers <rix0rrr@gmail.com>
    @njlynch @rix0rrr
    njlynch and rix0rrr authored Jan 5, 2021
    Configuration menu
    Copy the full SHA
    6c42338 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into njlynch/edge-synthesis-fix

    @mergify
    mergify[bot] authored Jan 5, 2021
    Configuration menu
    Copy the full SHA
    19ebcec View commit details
    Browse the repository at this point in the history