-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(elbv2): redirect listeners are always open #12766
Closed
1 of 2 tasks
MatthewMooreZA opened this issue
Jan 29, 2021
· 1 comment
· Fixed by #12768, aws-iot-builder-tools/iot-reference-architectures#1801, aws-samples/keycloak-on-aws#44, aws-samples/keycloak-on-aws#46 or aws-samples/amazon-emr-with-juicefs#80
Closed
1 of 2 tasks
(elbv2): redirect listeners are always open #12766
MatthewMooreZA opened this issue
Jan 29, 2021
· 1 comment
· Fixed by #12768, aws-iot-builder-tools/iot-reference-architectures#1801, aws-samples/keycloak-on-aws#44, aws-samples/keycloak-on-aws#46 or aws-samples/amazon-emr-with-juicefs#80
Labels
@aws-cdk/aws-elasticloadbalancingv2
Related to Amazon Elastic Load Balancing V2
feature-request
A feature should be added or improved.
needs-triage
This issue or PR still needs to be triaged.
Comments
MatthewMooreZA
added
feature-request
A feature should be added or improved.
needs-triage
This issue or PR still needs to be triaged.
labels
Jan 29, 2021
github-actions
bot
added
the
@aws-cdk/aws-elasticloadbalancingv2
Related to Amazon Elastic Load Balancing V2
label
Jan 29, 2021
MatthewMooreZA
added a commit
to MatthewMooreZA/aws-cdk
that referenced
this issue
Jan 29, 2021
mergify bot
pushed a commit
that referenced
this issue
Feb 25, 2021
) This change adds the ability to specify whether you'd like a redirect listener to be open or not. If you don't want the open ingress rule created you'll now be able to do the following: ```ts loadBalancer.addRedirect({ open: false }); ``` fixes #12766 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
This was referenced Mar 6, 2021
Merged
Closed
Closed
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-elasticloadbalancingv2
Related to Amazon Elastic Load Balancing V2
feature-request
A feature should be added or improved.
needs-triage
This issue or PR still needs to be triaged.
When calling
loadBalancer.addRedirect()
the listener is always created as open. This results in the creation of an ingress rule from all sources on the inbound port.Use Case
The use of ingress rules from all sources is not always desirable and it would be nice to have the option to turn this off.
Proposed Solution
Add an optional
open
property toApplicationLoadBalancerRedirectConfig
and pass this through when creating the listener. Defaultopen
to true to ensure backwards compatibility.This is a 🚀 Feature Request
The text was updated successfully, but these errors were encountered: