fix(aws-ecs): broken splunk-logging tag-option in fargate platform version 1.4
#13882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
SoManyHs
previously approved these changes
Mar 30, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
SoManyHs
approved these changes
Mar 30, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
bweigel
added a commit
to bweigel/aws-cdk
that referenced
this pull request
Mar 31, 2021
…latform version 1.4 (aws#13882)" This reverts commit e9d9299. Unfortunately the above commit leads to broken deployments that are caused by behaviors upstream (i.e. in the ECS backend): > Resource handler returned message: "Invalid request provided: Create TaskDefinition: Log driver splunk disallows options: splunk-tag (Service: AmazonECS; Status Code: 400; Error Code: ClientException; Request ID: d13abe56-36fa-4e81-b980-bf83789d4d0d; Proxy : null)" (RequestToken: 546a74e2-a2eb-ef75-43e7-231fe8927096, HandlerErrorCode: InvalidRequest) This means however, that the buggy behavior mentioned in aws#13881 persists.
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Mar 31, 2021
…version 1.4 (aws#13882) Set `splunk-tag` when `tag` is set. This will keep the API constant, however it will add an additional `splunk-tag` in the key-value `Options` property in `AWS::ECS::TaskDefinition`s - `LogConfiguration`. This is a very pragmatic approach. Feel free to suggest something else. closes aws#13881 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot
pushed a commit
that referenced
this pull request
Apr 2, 2021
…platform version 1.4 (#13882)" (#13892) This reverts commit e9d9299. Unfortunately the above commit leads to broken deployments that are caused by behaviors upstream (i.e. in the ECS backend): > Resource handler returned message: "Invalid request provided: Create TaskDefinition: Log driver splunk disallows options: splunk-tag (Service: AmazonECS; Status Code: 400; Error Code: ClientException; Request ID: d13abe56-36fa-4e81-b980-bf83789d4d0d; Proxy : null)" (RequestToken: 546a74e2-a2eb-ef75-43e7-231fe8927096, HandlerErrorCode: InvalidRequest) This means however, that the buggy behavior mentioned in #13881 persists. I am in communication with AWS support on this issue and will keep you posted. Sorry to have caused that mess. I should have marked the PR #13882 as draft before everything was clear. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…version 1.4 (aws#13882) Set `splunk-tag` when `tag` is set. This will keep the API constant, however it will add an additional `splunk-tag` in the key-value `Options` property in `AWS::ECS::TaskDefinition`s - `LogConfiguration`. This is a very pragmatic approach. Feel free to suggest something else. closes aws#13881 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…platform version 1.4 (aws#13882)" (aws#13892) This reverts commit e9d9299. Unfortunately the above commit leads to broken deployments that are caused by behaviors upstream (i.e. in the ECS backend): > Resource handler returned message: "Invalid request provided: Create TaskDefinition: Log driver splunk disallows options: splunk-tag (Service: AmazonECS; Status Code: 400; Error Code: ClientException; Request ID: d13abe56-36fa-4e81-b980-bf83789d4d0d; Proxy : null)" (RequestToken: 546a74e2-a2eb-ef75-43e7-231fe8927096, HandlerErrorCode: InvalidRequest) This means however, that the buggy behavior mentioned in aws#13881 persists. I am in communication with AWS support on this issue and will keep you posted. Sorry to have caused that mess. I should have marked the PR aws#13882 as draft before everything was clear. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
splunk-tagwhentagis set. This will keep the API constant, however it will add an additionalsplunk-tagin the key-valueOptionsproperty inAWS::ECS::TaskDefinitions -LogConfiguration.This is a very pragmatic approach. Feel free to suggest something else.
closes #13881
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license