revert: fix(aws-ecs): "broken splunk-logging tag-option in fargate platform version 1.4 (#13882)"
#13892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…latform version 1.4 (aws#13882)" This reverts commit e9d9299. Unfortunately the above commit leads to broken deployments that are caused by behaviors upstream (i.e. in the ECS backend): > Resource handler returned message: "Invalid request provided: Create TaskDefinition: Log driver splunk disallows options: splunk-tag (Service: AmazonECS; Status Code: 400; Error Code: ClientException; Request ID: d13abe56-36fa-4e81-b980-bf83789d4d0d; Proxy : null)" (RequestToken: 546a74e2-a2eb-ef75-43e7-231fe8927096, HandlerErrorCode: InvalidRequest) This means however, that the buggy behavior mentioned in aws#13881 persists.
|
|
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
bweigel
changed the title
tag-option in fargate platform version 1.4 (#13882)"tag-option in fargate platform version 1.4 (#13882)"
bweigel
changed the title
tag-option in fargate platform version 1.4 (#13882)"tag-option in fargate platform version 1.4 (#13882)"
SoManyHs
previously approved these changes
Apr 1, 2021
SoManyHs
previously approved these changes
Apr 1, 2021
|
@Mergifyio update |
|
Command
|
SoManyHs
approved these changes
Apr 2, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…platform version 1.4 (aws#13882)" (aws#13892) This reverts commit e9d9299. Unfortunately the above commit leads to broken deployments that are caused by behaviors upstream (i.e. in the ECS backend): > Resource handler returned message: "Invalid request provided: Create TaskDefinition: Log driver splunk disallows options: splunk-tag (Service: AmazonECS; Status Code: 400; Error Code: ClientException; Request ID: d13abe56-36fa-4e81-b980-bf83789d4d0d; Proxy : null)" (RequestToken: 546a74e2-a2eb-ef75-43e7-231fe8927096, HandlerErrorCode: InvalidRequest) This means however, that the buggy behavior mentioned in aws#13881 persists. I am in communication with AWS support on this issue and will keep you posted. Sorry to have caused that mess. I should have marked the PR aws#13882 as draft before everything was clear. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e9d9299.
Unfortunately the above commit leads to broken deployments that are caused by behaviors upstream (i.e. in the ECS backend):
This means however, that the buggy behavior mentioned in #13881 persists.
I am in communication with AWS support on this issue and will keep you posted.
Sorry to have caused that mess. I should have marked the PR #13882 as draft before everything was clear.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license