Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: Provide a Bill of Materials (BOM) for CDK dependencies #1406

Closed
thesurlydev opened this issue Dec 19, 2018 · 4 comments · Fixed by #1489
Closed

Java: Provide a Bill of Materials (BOM) for CDK dependencies #1406

thesurlydev opened this issue Dec 19, 2018 · 4 comments · Fixed by #1489
Labels
effort/medium Medium work item – several days of effort feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. feature-request A feature should be added or improved. language/java Related to Java bindings p1

Comments

@thesurlydev
Copy link
Contributor

To ease Maven dependency management, provide a BOM for the CDK dependencies.
@eladb eladb added enhancement language/java Related to Java bindings labels Dec 19, 2018
@eladb eladb changed the title Provide a Bill of Materials (BOM) for CDK dependencies Java: Provide a Bill of Materials (BOM) for CDK dependencies Dec 19, 2018
@srchase srchase added feature-request A feature should be added or improved. and removed enhancement labels Jan 3, 2019
eladb pushed a commit that referenced this issue Jan 7, 2019
feat: no more generated attribute types in CFN layer (L1)
bb71567 
Now that we can represent attributes as native strings and string lists,
this covers the majority of resource attributes in CloudFormation.

This change:

* String attributes are represented as `string` (like before).
* String list attribute are now represented as `string[]`.
* Any other attribute types are represented as `cdk.Token`.

Attributes that are represented as Tokens as of this change:

* amazonmq has a bunch of `Integer` attributes (will be solved by #1455)
* iot1click has a bunch of `Boolean` attributes
* cloudformation has a JSON attribute
* That's all.

A few improvements to cfn2ts:

* Auto-detect cfn2ts scope from package.json so it is more self-contained
  and doesn't rely on cdk-build-tools to run.
* Added a "cfn2ts" npm script to all modules so it is now possible
  to regenerate all L1 via "lerna run cfn2ts".
* Removed the premature optimization for avoiding code regeneration
  (it saved about 0.5ms).

Fixes #1406
@eladb eladb mentioned this issue Jan 7, 2019
Merged
4 tasks
eladb pushed a commit that referenced this issue Jan 8, 2019
feat: no more generated attribute types in CFN layer (L1) (#1489)
4d6d5ca 
Now that we can represent attributes as native strings and string lists,
this covers the majority of resource attributes in CloudFormation.

This change:

* String attributes are represented as `string` (like before).
* String list attribute are now represented as `string[]`.
* Any other attribute types are represented as `cdk.Token`.

Attributes that are represented as Tokens as of this change:

* amazonmq has a bunch of `Integer` attributes (will be solved by #1455)
* iot1click has a bunch of `Boolean` attributes
* cloudformation has a JSON attribute
* That's all.

A few improvements to cfn2ts:

* Auto-detect cfn2ts scope from package.json so it is more self-contained
  and doesn't rely on cdk-build-tools to run.
* Added a "cfn2ts" npm script to all modules so it is now possible
  to regenerate all L1 via "lerna run cfn2ts".
* Removed the premature optimization for avoiding code regeneration
  (it saved about 0.5ms).

Fixes #1406

BREAKING CHANGE: any `CfnXxx` resource attributes that represented a list of strings are now typed as `string[]`s (via #1144). Attributes that represent strings, are still typed as `string` (#712) and all other attribute types are represented as `cdk.Token`.
@eladb eladb reopened this Jan 8, 2019
@eladb
Copy link
Contributor

eladb commented Jan 8, 2019

Accidental reference of this issue

@RomainMuller RomainMuller added the effort/medium Medium work item – several days of effort label Jan 24, 2020
@drissamri
Copy link

I would love to see this one!

@ericzbeard ericzbeard added the feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. label Apr 7, 2021
@RomainMuller RomainMuller removed their assignment Jun 21, 2021
@rix0rrr rix0rrr added p1 and removed p2 labels Mar 16, 2022
@rix0rrr
Copy link
Contributor

rix0rrr commented Jan 25, 2023

I'm not quite sure what the request is here. If you are looking for a complete set of transitive dependencies, Maven can generate that for you:

mvn dependency:tree -Dverbose=true

If you mean something else, then would you mind clarifying what it is you need that Maven cannot give you? (in a new issue)

@rix0rrr rix0rrr closed this as completed Jan 25, 2023
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/medium Medium work item – several days of effort feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. feature-request A feature should be added or improved. language/java Related to Java bindings p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: no more generated attribute types in CFN layer (L1) aws/aws-cdk
7 participants
@thesurlydev @RomainMuller @rix0rrr @eladb @ericzbeard @srchase @drissamri