Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(init-templates): Region is fixed in Python template sample-app #14577

Closed
dev-julian opened this issue May 7, 2021 · 2 comments
Closed

(init-templates): Region is fixed in Python template sample-app #14577

dev-julian opened this issue May 7, 2021 · 2 comments
Assignees
@NGL321
Labels
guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged.

Comments

@dev-julian
Copy link

❓ General Issue

The Question

In the init templates (packages/aws-cdk/lib/init-templates) both v1 and v2 of the sample-app Python template have region us-west-2 as a fixed parameter in (v1|v2)/sample-app/python/app.template.py.
This can cause issues when following along cdkworkshop.com, especially for people new to AWS and CDK.

Is it necessary to have the region fixed here, or can this be removed, so the default region is used for bootstrapping and deployment?

Environment

  • CDK CLI Version:
  • Module Version:
  • Node.js Version:
  • OS:
  • Language (Version): Python

Other information
@dev-julian dev-julian added guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels May 7, 2021
@peterwoodworth peterwoodworth mentioned this issue May 12, 2021
Merged
@peterwoodworth
Copy link
Contributor

Thank you for letting us know about this @dev-julian! I've created a PR that fixes this and it should be changed in the next version

mergify bot pushed a commit that referenced this issue May 12, 2021
@peterwoodworth
chore: remove fixed region in python sample app (#14667)
0df9f9b 
Sourced from guidance issue #14577 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
@peterwoodworth @hollanddd
chore: remove fixed region in python sample app (aws#14667)
310111e 
Sourced from guidance issue aws#14577 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NGL321 NGL321

Labels
guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NGL321 @peterwoodworth @dev-julian