Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elbv2: Set load balancer name seems doesn't work #1481

Closed
mouyigang opened this issue Jan 4, 2019 · 0 comments · Fixed by #1486
Closed

elbv2: Set load balancer name seems doesn't work #1481

mouyigang opened this issue Jan 4, 2019 · 0 comments · Fixed by #1486
Assignees
@eladb
Labels
@aws-cdk/aws-elasticloadbalancing Related to Amazon Elastic Load Balancing bug This issue is a bug.

Comments

@mouyigang
Copy link

my code:

new elbv2.ApplicationLoadBalancer(parent, 'ALB', { 
        vpc, 
        internetFacing: true,
        loadBalancerName: 'myalb'
    });

Load balancer got created:
Name: ECSGr-ALB1F-1RGPT2HCXKOZL

Expect to be 'myalb'
@rix0rrr rix0rrr added bug This issue is a bug. @aws-cdk/aws-elasticloadbalancing Related to Amazon Elastic Load Balancing labels Jan 6, 2019
@eladb eladb self-assigned this Jan 7, 2019
eladb pushed a commit that referenced this issue Jan 7, 2019
fix(elbv2): unable to specify load balancer name
b053cdb 
Since #973, the renames of CFN properties from "name" to "xxxName" were
removed. But the ELBv2 library still used `loadBalancerName`. The reason
this was not discovered was because we are splatting `additionalProps` of
type `any`, and this caused the type checker to stop verifying property
names.

Fixes #1481
@eladb eladb mentioned this issue Jan 7, 2019
Merged
4 tasks
eladb pushed a commit that referenced this issue Jan 7, 2019
fix(elbv2): unable to specify load balancer name (#1486)
5b24583 
Since #973, the renames of CFN properties from "name" to "xxxName" were
removed. But the ELBv2 library still used `loadBalancerName`. The reason
this was not discovered was because we are splatting `additionalProps` of
type `any`, and this caused the type checker to stop verifying property
names.

Fixes #1481
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

Labels
@aws-cdk/aws-elasticloadbalancing Related to Amazon Elastic Load Balancing bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(elbv2): unable to specify load balancer name aws/aws-cdk
3 participants
@rix0rrr @eladb @mouyigang