@aws-cdk/aws-ecs-patterns: Add ability to set healthCheck for QueueProcessingFargateService

[paya-cz]

QueueProcessingFargateService currently does not offer healthCheck options property, even though it is very simple to add it here:

aws-cdk/packages/@aws-cdk/aws-ecs-patterns/lib/fargate/queue-processing-fargate-service.ts

Line 124 in 8668e15

this.taskDefinition.addContainer(containerName, {

So, there is no good way to set a healthCheck on a container.

Use Case

I use healthcheck to make sure the tasks are healthy. Fargate ignores HEALTHCHECK instruction in Dockerfile, so I am forced to supply the healthCheck instruction via CDK. However, QueueProcessingFargateService does not let me.

Proposed Solution

Add a healthcheck property here:

aws-cdk/packages/@aws-cdk/aws-ecs-patterns/lib/fargate/queue-processing-fargate-service.ts

Line 10 in 8668e15

export interface QueueProcessingFargateServiceProps extends QueueProcessingServiceBaseProps {

Pass it to the container here:

aws-cdk/packages/@aws-cdk/aws-ecs-patterns/lib/fargate/queue-processing-fargate-service.ts

Line 124 in 8668e15

this.taskDefinition.addContainer(containerName, {

Workaround

This is not nice, but works.

// @ts-ignore
service.taskDefinition.defaultContainer!.props.healthCheck = <ecs.HealthCheck>{
    command: ['CMD', 'node /app/healthcheck.js'],
    interval: cdk.Duration.seconds(15),
    retries: 3,
    timeout: cdk.Duration.seconds(5),
};

---

This is a 🚀 Feature Request

[paya-cz]

Same problem for ScheduledFargateTask:

aws-cdk/packages/@aws-cdk/aws-ecs-patterns/lib/fargate/scheduled-fargate-task.ts

Line 118 in 8668e15

this.taskDefinition.addContainer('ScheduledContainer', {

[peterwoodworth]

Hey @paya-cz, sorry for the slow response

Would you like to submit a PR for this feature request yourself? I can't guarantee anyone from the team will be able to tackle this anytime soon

[paya-cz]

This issue seems to be somewhat related to #8320, perhaps both issues could be tackled at the same time one day.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.