Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-backup: BackupPlanRule support for recovery point tags #25671

Closed
2 tasks
delenamalan opened this issue May 22, 2023 · 2 comments · Fixed by #25863
Closed
2 tasks

aws-backup: BackupPlanRule support for recovery point tags #25671

delenamalan opened this issue May 22, 2023 · 2 comments · Fixed by #25863
Labels
@aws-cdk/aws-backup Related AWS Backup effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@delenamalan
Copy link

delenamalan commented May 22, 2023 •
edited
Loading

Describe the feature

It would be nice to be able to add recovery point tags to BackupPlanRule. See the RecoveryPointTags property of BackupRuleResourceType.

Use Case

I want all backups that have been created with AWS Backup to have the same tags.

Proposed Solution

Add a parameter to the BackupPlanRule class for recovery point tags.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.79.1

Environment details (OS name and version, etc.)

Mac OS 13.3.1 Python 3.7.13
@delenamalan delenamalan added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 22, 2023
@github-actions github-actions bot added the @aws-cdk/aws-backup Related AWS Backup label May 22, 2023
@peterwoodworth peterwoodworth added good first issue Related to contributions. See CONTRIBUTING.md p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels May 22, 2023
@peterwoodworth
Copy link
Contributor

Thanks for the request, we would be happy to accept a PR for this.

Until this is implemented, you can use escape hatches to manually add the property to the template

@go-to-k go-to-k mentioned this issue Jun 6, 2023
Merged
@mergify mergify bot closed this as completed in #25863 Jun 8, 2023
mergify bot pushed a commit that referenced this issue Jun 8, 2023
@go-to-k
feat(backup): add recovery point tags param to backup plan rule (#25863)
445543c 
This PR adds a `RecoveryPointTags` property to `BackupPlanRule`.

Closes #25671

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-backup Related AWS Backup effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(backup): add recovery point tags param to backup plan rule go-to-k/aws-cdk
2 participants
@delenamalan @peterwoodworth