Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support windows containers #2574

Closed
SoManyHs opened this issue May 17, 2019 · 0 comments · Fixed by #3376
Closed

Support windows containers #2574

SoManyHs opened this issue May 17, 2019 · 0 comments · Fixed by #3376
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md

Comments

@SoManyHs
Copy link
Contributor

With #2453, we are supporting other AMIs available through SSM parameters. We should also be able to support pulling windows containers:

https://docs.aws.amazon.com/AmazonECS/latest/developerguide/retrieve-ecs-optimized_AMI.html
@SoManyHs SoManyHs added good first issue Related to contributions. See CONTRIBUTING.md feature-request A feature should be added or improved. @aws-cdk/aws-ecs Related to Amazon Elastic Container labels May 17, 2019
@nmussy nmussy mentioned this issue Jul 22, 2019
Merged
eladb pushed a commit that referenced this issue Jul 25, 2019
feat(ecs): ECS optimized Windows images (#3376)
6c0bf4a 
* deprecate `EcsOptimizedAmi` for `EcsOptimizedImage`
* constructor(props) replaced by strongly typed static methods
* Windows AMI support
* deprecate `EcsOptimizedAmi`, `EcsOptimizedAmiProps`
* will require changes on v2 shipment #3398

Fixes #2574
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ecs): ECS optimized Windows images logicgram/aws-cdk
1 participant
@SoManyHs