Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipelines: UpdatePipeline stage fails on invalid S3 policy #27542

Closed
ekeyser opened this issue Oct 14, 2023 · 15 comments
Closed

pipelines: UpdatePipeline stage fails on invalid S3 policy #27542

ekeyser opened this issue Oct 14, 2023 · 15 comments
Labels
@aws-cdk/pipelines CDK Pipelines library bug This issue is a bug. effort/medium Medium work item – several days of effort p2

Comments

@ekeyser
Copy link

ekeyser commented Oct 14, 2023

Describe the bug

Upgraded from v2.100.0 to v2.101.0

Upon deployment received the following message (in CodeBuild) for the UpdatePipeline stage. Currently using pipelines to facilitate creation of CodePipeline.

Resource handler returned message: "Policy has invalid action (Service: S3, Status Code: 400, Request ID: XSE075TJK1K319VC, Extended Request ID: ORsos9yz7sdctnOg4AT8QiCjo9irN0v0nBFD/vW/ZxEMW1Y2PclX9Ve0o6lCstdGxQpaHdJjZi8=)" (RequestToken: 3d521b5c-2f09-4c59-09a6-cb30ccdf294e, HandlerErrorCode: GeneralServiceException)

Expected Behavior

No difference to our CodePipeline behavior after upgrading.

Current Behavior

Deploys all the way through without issue on v2.100.0. Fails with above error on v2.101.0.

Reproduction Steps

Implement CodePipelines using cdk pipelines cdk sub-module. Deploy using v2.100.0. Upgrade to v2.101.0. Probably need some lambda assets if this is related to staging S3 assets.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.101.0

Framework Version

No response

Node.js Version

v18.18.1

OS

LInux

Language

TypeScript

Language Version

5.2.2

Other information

No response

@ekeyser ekeyser added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 14, 2023
@github-actions github-actions bot added the @aws-cdk/pipelines CDK Pipelines library label Oct 14, 2023
@days-later
Copy link

i'm seeing the same error and i'm not using pipelines.

i guess this could be the reason: #27416 (comment)

@silo-su
Copy link

silo-su commented Oct 14, 2023

I had same issue after upgrading to v2.101.0. Need to downgrade to v2.100.0 to get it worked.

@Khoulaiz
Copy link

My self modifying Pipeline failed after upgrading to this version. Please revert/fix the patch ASAP or warn your users about this version.

@NanHeSam
Copy link

+1, running into the same issue initializing a new pipeline

@panamclipper707
Copy link

  • 1 same here

@denys-tyshetskyy
Copy link

Any ETA on when this is going to be fixed?

@manu-remsense
Copy link

+1 having the exact same issue

1 similar comment
@roamingthings
Copy link

+1 having the exact same issue

@Khoulaiz
Copy link

more generic bug is #27547

@HMthyl
Copy link

HMthyl commented Oct 16, 2023

+1 Our SelfMutate step is also failing today; even on reverting to v2.100.0 and lower.

@avsteel
Copy link

avsteel commented Oct 16, 2023

can confirm was facing same issue in SelfMutate step but latest aws-cdk 2.101.1 appears to have fixed the issue for me, now able to release successfully.

@manu-remsense
Copy link

Agree with @avsteel, the latest 2.101.1 resolved the issue for me.

@HMthyl
Copy link

HMthyl commented Oct 17, 2023

I'm the same as avsteel and manu-remsense - 2.101.1 fixed this for us!

@pahud
Copy link
Contributor

pahud commented Oct 17, 2023

could related to #27416 (comment)
I am closing this issue for now and feel free to reopen it if any concerns.

@pahud pahud closed this as completed Oct 17, 2023
@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Oct 17, 2023
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/pipelines CDK Pipelines library bug This issue is a bug. effort/medium Medium work item – several days of effort p2
Projects
None yet
Development

No branches or pull requests