Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opensearchservice.EngineVersion: no support for OpenSearch version 2.9 #27574

Closed
ShaiBarak opened this issue Oct 17, 2023 · 3 comments · Fixed by #27612
Closed

opensearchservice.EngineVersion: no support for OpenSearch version 2.9 #27574

ShaiBarak opened this issue Oct 17, 2023 · 3 comments · Fixed by #27612
Labels
@aws-cdk/aws-opensearch Related to the @aws-cdk/aws-opensearchservice package effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@ShaiBarak
Copy link

Describe the bug

OpenSearch 2.9 is out but not available to create domain cluster (via Domain.Builder in cdk) with version 2.9 as EngineVersion class does not support it
(enum has until 2.7 version(EngineVersion.OPENSEARCH_2_7))
and cannot workaround this with a string "OPENSEARCH_2_9"

Expected Behavior

it will be possible to create a domain with EngineVersion = OPENSEARCH_2_9
in order to create opensearch cluster with version 2.9 via cdk

Current Behavior

domain version via cdk could be only until 2.7 due to lack of EngineVersion support for it

Reproduction Steps

Create a OpenSearch domain via cdk like so :
IDomain os = Domain.Builder
.create(this, "OpenSearchService")
.domainName(domainName)
.version(EngineVersion.OPENSEARCH_2_9)

Possible Solution

refactor EngineVersion to have
OPENSEARCH_2_9 = software.amazon.jsii.JsiiObject.jsiiStaticGet(software.amazon.awscdk.services.opensearchservice.EngineVersion.class, "OPENSEARCH_2_9", software.amazon.jsii.NativeType.forClass(software.amazon.awscdk.services.opensearchservice.EngineVersion.class));

Additional Information/Context

No response

CDK CLI Version

2.101.1

Framework Version

No response

Node.js Version

18.18.0

OS

windows

Language

Java

Language Version

Java 17

Other information

No response

@ShaiBarak ShaiBarak added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 17, 2023
@github-actions github-actions bot added the @aws-cdk/aws-opensearch Related to the @aws-cdk/aws-opensearchservice package label Oct 17, 2023
@ShaiBarak ShaiBarak changed the title (module name): (short issue description) software.amazon.awscdk.services.opensearchservice.EngineVersion: no support for OpenSearch version 2.9 Oct 17, 2023
@ShaiBarak ShaiBarak changed the title software.amazon.awscdk.services.opensearchservice.EngineVersion: no support for OpenSearch version 2.9 opensearchservice.EngineVersion: no support for OpenSearch version 2.9 Oct 17, 2023
@kaizencc
Copy link
Contributor

Hi @ShaiBarak, I'm acknowledging this as a feature request to add engine version 2.9 to the enum list. We accept contributions and usually rely on the community to keep our enum list up-to-date.

In the meantime, you should be able to unblock yourself by providing EngineVersion.openSearch('2.7'); as your runtime.

@kaizencc kaizencc added good first issue Related to contributions. See CONTRIBUTING.md p2 feature-request A feature should be added or improved. effort/small Small work item – less than a day of effort and removed bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 17, 2023
@ShaiBarak
Copy link
Author

Thanks @kaizencc !

@mergify mergify bot closed this as completed in #27612 Oct 19, 2023
mergify bot pushed a commit that referenced this issue Oct 19, 2023
[Amazon OpenSearch Service now supports OpenSearch version 2.9](https://aws.amazon.com/about-aws/whats-new/2023/10/amazon-opensearch-service-opensearch-version-2-9/). This PR adds the new engine version.

Closes #27574

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-opensearch Related to the @aws-cdk/aws-opensearchservice package effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants