Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws_ec2): Add support for i4g instances in InstanceClass #27631

Closed
2 tasks
khushail opened this issue Oct 20, 2023 · 2 comments · Fixed by #27639
Closed
2 tasks

(aws_ec2): Add support for i4g instances in InstanceClass #27631

khushail opened this issue Oct 20, 2023 · 2 comments · Fixed by #27639
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@khushail
Copy link
Contributor

Describe the feature

As of now AWS CDK doesn't support Instance class for i4g instances according to this latest doc

Add support for this instance class type.

Use Case

NA

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

NA

Environment details (OS name and version, etc.)

NA
@khushail khushail added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 20, 2023
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Oct 20, 2023
@khushail
Copy link
Contributor Author

This is supported by Cloudformation , hence should be implementable by CDK.

@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Oct 20, 2023
@tam0ri tam0ri mentioned this issue Oct 22, 2023
Merged
@mergify mergify bot closed this as completed in #27639 Oct 24, 2023
mergify bot pushed a commit that referenced this issue Oct 24, 2023
@tam0ri
feat(ec2): support for i4g instance types in aws-ec2 (#27639)
039071d 
The I4g instance types were [introduced](https://aws.amazon.com/about-aws/whats-new/2023/05/amazon-ec2-i4g-storage-optimized-instances/?nc1=h_ls) in May 2023.
The instance types are supported in [CloudFormation](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ec2-instance.html#cfn-ec2-instance-instancetype).

Closes #27631

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot mentioned this issue Nov 1, 2023
Closed
mrgrain pushed a commit that referenced this issue Nov 1, 2023
@tam0ri @mrgrain
feat(ec2): support for i4g instance types in aws-ec2 (#27639)
9ff3fff 
The I4g instance types were [introduced](https://aws.amazon.com/about-aws/whats-new/2023/05/amazon-ec2-i4g-storage-optimized-instances/?nc1=h_ls) in May 2023.
The instance types are supported in [CloudFormation](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ec2-instance.html#cfn-ec2-instance-instancetype).

Closes #27631

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ec2): support for i4g instance types in aws-ec2 tam0ri/aws-cdk
1 participant
@khushail