Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotswap: Evaluate cloudformation template doesn't look at multi-nested stacks #28077

Closed
Amplifiyer opened this issue Nov 21, 2023 · 1 comment
Closed

Hotswap: Evaluate cloudformation template doesn't look at multi-nested stacks #28077

Amplifiyer opened this issue Nov 21, 2023 · 1 comment
Labels
@aws-cdk/aws-cloudformation Related to AWS CloudFormation bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. p0

Comments

@Amplifiyer
Copy link
Contributor

Describe the bug

This line here doesn't actually finds the nested stack in the tree but only at the top level which causes references made to second (or more) level nested stacks return undefined. This causes hotswap to fail

Expected Behavior

Correctly evaluate the cloudformation template for hotswap when the attribute references is in second level nested stack

Current Behavior

This line here doesn't actually finds the nested stack in the tree but only at the top level

Reproduction Steps

Have a two tiered nested stack where any resource relies on an attribute (such as output) of second level nested stack. Perform hotswap.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.110.0

Framework Version

No response

Node.js Version

18.17.0

OS

Macos

Language

TypeScript

Language Version

No response

Other information

No response
@Amplifiyer Amplifiyer added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 21, 2023
@github-actions github-actions bot added the @aws-cdk/aws-cloudformation Related to AWS CloudFormation label Nov 21, 2023
@Amplifiyer Amplifiyer mentioned this issue Nov 21, 2023
Merged
@udaypant udaypant added the p0 label Nov 21, 2023
udaypant added a commit that referenced this issue Nov 21, 2023
@udaypant
fix(cli): hotswap cannot evaluate nested stacks within nested stacks (#…
6004a17 
…28080)

This line 


https://github.com/aws/aws-cdk/blob/25ee8ef61d6b33628923a0fee4c042a0f0f2441e/packages/aws-cdk/lib/api/evaluate-cloudformation-template.ts#L390

doesn't actually finds the nested stack in the tree but only at the top
level which causes references made to second (or more) level nested
stacks return undefined. This causes hotswap to fail
Closes #<issue number here>. #28077

----

*By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license*
@rix0rrr rix0rrr closed this as completed Nov 21, 2023
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot mentioned this issue Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-cloudformation Related to AWS CloudFormation bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. p0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@udaypant @rix0rrr @Amplifiyer