Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeline: should allow crossRegionReplicationBuckets passthrough to underlying CodePipeline construct #28446

Closed
1 of 2 tasks
ahammond opened this issue Dec 21, 2023 · 2 comments · Fixed by #28447 · May be fixed by stack-spot/app-handler-functions-template#2, stack-spot/eks-env-ts-template#2 or stack-spot/web-react-deploy#4
Labels
@aws-cdk/pipelines CDK Pipelines library effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@ahammond
Copy link
Contributor

ahammond commented Dec 21, 2023

Describe the feature

When deploying large numbers of CdkPipelines, we consume a lot of S3 buckets. There is already a way to reuse the artifact buckets across multiple CdkPipelines. We would like to also reuse the cross region replication buckets. To do this, we need to pass through the crossRegionReplicationBuckets property from the Pipeline object to the internal CodePipeline object.

Use Case

There's a hard limit of 1000 S3 buckets per account. Our CdkPipelines deployer account supports pipelines from roughly 130 repos at this time and recently crossed the 900 bucket line. We need to be able to keep scaling out.

Proposed Solution

Pass the crossRegionReplicationBuckets through, same has how reuseCrossRegionSupportStacks is passed through:
https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/pipelines/lib/codepipeline/codepipeline.ts#L458

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.115.0

Environment details (OS name and version, etc.)

irrelevant

@ahammond ahammond added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 21, 2023
@github-actions github-actions bot added the @aws-cdk/pipelines CDK Pipelines library label Dec 21, 2023
@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Dec 21, 2023
@khushail
Copy link
Contributor

@ahammond ,thanks for submitting the FR and your contribution on PR.

@mergify mergify bot closed this as completed in #28447 Jan 8, 2024
mergify bot pushed a commit that referenced this issue Jan 8, 2024
Closes #28446.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Copy link

github-actions bot commented Jan 8, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment