-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[apigateway] L2 Construct for Api Gateway V2 (WebSocket) #2872
[apigateway] L2 Construct for Api Gateway V2 (WebSocket) #2872
Comments
I have the base of it (used for a demo), will tidy up, and get a PR submitted |
Looking into the details of my classes, ApiGatewayV2 has a lot of overlap with ApiGateway (v1), but very little compatibility. My recommendation would be to split the modules and have an apigateway v2 module that can evolve.
|
Any update for this? |
I am also looking for creating a WebSocket API with cdk. |
Hey all. I am traveling at the moment and I have no access to my computer. I should have something later this week, probably not a finalized one but a basis for getting something working.
Julien
… Le 26 août 2019 à 17:37, BrianG13 ***@***.***> a écrit :
I am also looking for creating a WebSocket API with cdk.
Not find in any doc the option to do this.
@julienlepine you have already a working code?? can you refer me to it?? thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Hey, I continue trying to do something work also. Another problem is that, I can't create&deploy at the same "cdk deploy hello-brian" command.
Do you find any step here that it’s wrong? Or something missing?? @julienlepine any news? |
Here is the code for my class (my computer is failing me, sorry for the delay).
|
And the usage:
|
I have some time now, anyone wants to take it, or are you happy for me to re-own it? |
@nija-at is currently the maintainer of the apigateway module and I think started to think about v2. You guys should sync up. |
Is there a timeframe for when this will be worked on? Will this take a couple more months or could there be a preview out within a few weeks? Would love to see this happen! |
same, waiting for this. |
Unfortunately, we've not had a chance to get to this as yet, and don't have a timeframe. @spaceemotion, @binarythinktank and anyone who has 👍'ed the comment, please do the same on the main issue description, so it gets the right priority. Thanks! |
@BrianG13 , thanks a lot for your python example, it helped me a lot! I am running with my TS implementation into the exact same problem that you describe:
Did you ever manage to resolve that specific problem? I currently need to comment out the following two lines before I initially deploy, otherwise I'll get
Update, I think I figured it out: |
Hello there, I'm trying to use WebSocket via VPC_LINK, are the "ConnectionId" params missing from CDK or is not managed through CloudFormation? Error in CDK version 1.28:
|
Hi there, is there a working cdk WebSocket with API gateway example I could look at please? |
feat(apigatewayv2): add support for WebSocket APIs BREAKING CHANGE: `HttpApiMapping` (and related interfaces for `Attributed` and `Props`) has been renamed to `ApiMapping` * **apigatewayv2:** `CommonStageOptions` has been renamed to `StageOptions` * **apigatewayv2:** `HttpStage.fromStageName` has been removed in favour of `HttpStage.fromHttpStageAttributes` * **apigatewayv2:** `DefaultDomainMappingOptions` has been removed in favour of `DomainMappingOptions` * **apigatewayv2:** `HttpApiProps.defaultDomainMapping` has been changed from `DefaultDomainMappingOptions` to `DomainMappingOptions` * **apigatewayv2:** `HttpApi.defaultStage` has been changed from `HttpStage` to `IStage` * **apigatewayv2:** `IHttpApi.defaultStage` has been removed closes aws#2872 Some notes: 1. Only Lambda Integration is currently supported 2. No support for `IntegrationResponse` and `RouteResponse`. 3. The `$default` stageName does not seem to work for WebSocket APIs. Therefore modified the API for defaultStage in the API. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
I still struggle to have my lambda triggered by the websockets API Gateway. I added the lambda as integration target but in the lambda the API Gateway does not occur as trigger. When trying to add it manually I can't even select the websockets API gateway |
@chtpl Hey dude, did u resolve your issue? I'm facing the same problem :( |
unfortunately not |
Thanks for this! I ran into the same problem in my Cloudformation Template. The Api Gateway docs weren't explicitly clear on this matter either. They should mention common dependencies on the page of the resource, instead of hoping that we'll read the whole docs end-to-end (and stumble upon the relevant rule) before starting to implement stuff. |
WebSocket APIs in API gateway use a separate model from the REST APIs.
Having a set of models that provide the functionalities of API Gateway V2 in a more integrated way would simplify deployment of WebSocket APIs.
The text was updated successfully, but these errors were encountered: