(ec2): BastionHost deviceName example is wrong

[rantoniuk]

Describe the bug

The example listed in the documentation renders:

1:27:28 PM | CREATE_FAILED        | AWS::EC2::Instance                    | BastionHost30F9ED05
Invalid device name EBSBastionHost (Service: AmazonEC2; Status Code: 400; Error Code: InvalidBlockDeviceMapping; Request ID: 3bd4a132-0230-4769-8ef5-5ceaa559ad36; P
roxy: null)

The proposed deviceName does not align with the supported ones.

Additionally:

volume: ec2.BlockDeviceVolume.ebs(10, { encrypted: true }),

has an implicit volumeType default of GP2, while it should now be GP3 by default if not specified.

Expected Behavior

The example from documentation should work when copy-pasted.

Current Behavior

As above.

Reproduction Steps

As above.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.127.0 (build 6c90efc)

Framework Version

No response

Node.js Version

v18.18.2

OS

MacOS

Language

TypeScript

Language Version

No response

Other information

No response

[pahud]

Yes I guess we should have a PR to fix that. Thanks for the report. Are you interested to submit a PR for that?

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

[rantoniuk]

@msambol any thoughts about GP2 vs GP3 default?

[hoegertn]

@msambol any thoughts about GP2 vs GP3 default?

Changing this might lead to recreation of disks and is a breaking change. So only possible with feature flags.

[rantoniuk]

@hoegertn so I understand that you're going to add a new feature flag for this so that newly created instances are actually following the current AWS platform defaults without explicitly setting this, right?
If there a related issue I can watch regarding this, I'd be interested to subscribe to it!

[hoegertn]

The implementation of BastionHost and Instance that it uses internally currently does not specify the volume type but uses the CloudFormation default. So, if this should be changed, that needs to be implemented and then guarded by a feature flag to not break existing users. I'm not sure if this is planned currently.

[rantoniuk]

Ah! I assumed it was internally hardcoded as a default in aws-cdk and wasn't aware it's coming from CloudFormation - so it would need actually an update on the platform side for the Cloudformation default to be updated.
Thanks for the info!