aws-cdk: Duration.parse() does not handle units larger then days

[mattaschmann]

Describe the bug

While trying to use cdk.Duration.parse() with the strings P1Y and P1M it threw errors. Looking at the source (

aws-cdk/packages/aws-cdk-lib/core/lib/duration.ts

Lines 69 to 89 in 43e681e

	public static parse(duration: string): Duration {
	const matches = duration.match(/^P(?:(\d+)D)?(?:T(?:(\d+)H)?(?:(\d+)M)?(?:(\d+)S)?)?$/);
	if (!matches) {
	throw new Error(`Not a valid ISO duration: ${duration}`);
	}
	const [, days, hours, minutes, seconds] = matches;
	if (!days && !hours && !minutes && !seconds) {
	throw new Error(`Not a valid ISO duration: ${duration}`);
	}
	return Duration.millis(
	_toInt(seconds) * TimeUnit.Seconds.inMillis
	+ (_toInt(minutes) * TimeUnit.Minutes.inMillis)
	+ (_toInt(hours) * TimeUnit.Hours.inMillis)
	+ (_toInt(days) * TimeUnit.Days.inMillis),
	);
	function _toInt(str: string): number {
	if (!str) { return 0; }
	return Number(str);
	}
	}

) it's obvious that any unit larger then days are not handled.

Expected Behavior

As the documentation for this message states:

    /**
     * Parse a period formatted according to the ISO 8601 standard
     *
     * @see https://www.iso.org/standard/70907.html
     * @param duration an ISO-formatted duration to be parsed.
     * @returns the parsed `Duration`.
     */

It should correctly handle all valid ISO 8601 strings. Either that, or the documentation needs to indicate it doesn't handled anything larger then days.

Current Behavior

Throws an error on any unit larger then a day.

Reproduction Steps

import * as cdk from 'aws-cdk-lib'

cdk.Duration.parse('P1Y')
cdk.Duration.parse('P1M')

Possible Solution

Add larger units to the regular expression and handle them, or change the documentation to indicate that they are not handled.

Additional Information/Context

No response

CDK CLI Version

2.115.0 (build 58027ee)

Framework Version

No response

Node.js Version

v18.15.0

OS

macOS: 14.3.1 (23D60)

Language

TypeScript

Language Version

No response

Other information

No response

[pahud]

Thank you for the report.

And @msambol thanks for your PR as always!

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.