Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDKv3-02: Update aws-lambda-nodejs in aws-cdk-lib #29836

Closed
Tracked by #29694
TheRealAmazonKendra opened this issue Apr 15, 2024 · 2 comments · Fixed by #30099
Closed
Tracked by #29694

SDKv3-02: Update aws-lambda-nodejs in aws-cdk-lib #29836

TheRealAmazonKendra opened this issue Apr 15, 2024 · 2 comments · Fixed by #30099
Assignees
@scanlonp

Comments

@TheRealAmazonKendra
Copy link
Contributor

TheRealAmazonKendra commented Apr 15, 2024 •
edited by scanlonp
Loading

Context

The AWS SDK V2 is being deprecated. We need to remove all uses of it from the CDK.

Considerations

  • Should be completed after SDKv3-01 and follow the same/similar plan for deprecation of v2. Consider adding a warning for now that we will remove use of SDKv2 in a few weeks and then make this change then.
  • Be aware of the node 20 upgrade happening in this package as well.

Task Description

We do not use sdk v2 directly in the package. However, we have logic around keeping the sdk from being bundled into the handler. That logic is tied to the runtime, and assumes the corresponding sdk version is included in the lambda runtime. We need to warn users that upgrading their lambda runtime can break handler code that uses sdk v2 calls.

The deprecation date for node16 Lambda runtimes is June 12, 2024. Lambda will block function creation on July 16, 2024 and will block function updates on August 15, 2024.

Acceptance Criteria

  1. Remove all other uses of SDKv2.
  2. Update relevant integ tests and verify that the impacted custom resources successfully deploy and behave as expected.
@TheRealAmazonKendra TheRealAmazonKendra mentioned this issue Apr 15, 2024
Open
10 tasks
This was referenced Apr 22, 2024
Closed
Closed
@scanlonp scanlonp self-assigned this Apr 22, 2024
@github-actions github-actions bot mentioned this issue May 1, 2024
Closed
@scanlonp scanlonp mentioned this issue May 8, 2024
Merged
@mergify mergify bot closed this as completed in #30099 May 8, 2024
mergify bot pushed a commit that referenced this issue May 8, 2024
@scanlonp
chore(lambda-nodejs): clean up sdk v2 references and warn about runti…
e9e800f 
…me updates related to sdk bundling (#30099)

Closes #29836.

While sdk v2 was not being used directly in the construct, we had some remnants of its use. Added a warning for users of Node 16 who do not bundle the sdk on what it will take to update to newer node versions. Also updated integ tests to make actual sdk v3 calls as well as clean up false references to v2.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@scanlonp scanlonp

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@aws-cdk-automation @TheRealAmazonKendra @scanlonp @vinayak-kukreja