Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(neptune): copyTagsToSnapshot is missing in the DatabaseCluster Construct #30087

Closed
1 of 2 tasks
mazyu36 opened this issue May 7, 2024 · 3 comments · Fixed by #30092 or rwlxxvii/containers#140 · May be fixed by NOUIY/aws-solutions-constructs#105, kazimanzurrashid/aws-scheduler-go#821 or NOUIY/aws-solutions-constructs#106
Closed
1 of 2 tasks

(neptune): copyTagsToSnapshot is missing in the DatabaseCluster Construct #30087

mazyu36 opened this issue May 7, 2024 · 3 comments · Fixed by #30092 or rwlxxvii/containers#140 · May be fixed by NOUIY/aws-solutions-constructs#105, kazimanzurrashid/aws-scheduler-go#821 or NOUIY/aws-solutions-constructs#106
Labels
@aws-cdk/aws-neptune Related Amazon Neptune effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/needs-review

Comments

@mazyu36
Copy link
Contributor

mazyu36 commented May 7, 2024

Describe the feature

In the DatabaseCluster Construct, copyTagsToSnapshot is missing.

Use Case

Use this when you want to copy tags to snapshots.

Proposed Solution

Add copyTagsToSnapshot to the DatabaseCluster Construct.

const cluster = new neptune.DatabaseCluster(this, 'Database', {
  vpc,
  instanceType: neptune.InstanceType.R5_LARGE,
  copyTagsToSnapshot: true, // Add
});

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.140.0

Environment details (OS name and version, etc.)

MacOS
@mazyu36 mazyu36 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 7, 2024
@github-actions github-actions bot added the @aws-cdk/aws-neptune Related Amazon Neptune label May 7, 2024
@mazyu36 mazyu36 mentioned this issue May 7, 2024
Merged
1 task
@ashishdhingra ashishdhingra self-assigned this May 7, 2024
@ashishdhingra ashishdhingra added investigating This issue is being investigated and/or work is in progress to resolve the issue. p2 effort/small Small work item – less than a day of effort pr/needs-review and removed needs-triage This issue or PR still needs to be triaged. investigating This issue is being investigated and/or work is in progress to resolve the issue. labels May 7, 2024
@ashishdhingra
Copy link
Contributor

@mazyu36 Thanks for your PR contribution.

This was referenced May 13, 2024
Closed
Closed
@ashishdhingra ashishdhingra removed their assignment May 14, 2024
@mergify mergify bot closed this as completed in #30092 May 27, 2024
mergify bot pushed a commit that referenced this issue May 27, 2024
@mazyu36
feat(neptune): add copyTagsToSnapshot property to the DatabaseCluster…
ba8edb3 
… Construct (#30092)

### Issue # (if applicable)

Closes #30087 

### Reason for this change
As described in the issue.



### Description of changes
Add copyTagsToSnapshot property to the DatabaseCluster Construct.


### Description of how you validated changes
Add both unit tests and integ tests.


### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot mentioned this issue Jun 1, 2024
Closed
vdahlberg pushed a commit to vdahlberg/aws-cdk that referenced this issue Jun 10, 2024
@mazyu36
feat(neptune): add copyTagsToSnapshot property to the DatabaseCluster…
7b30b3f 
… Construct (aws#30092)

### Issue # (if applicable)

Closes aws#30087 

### Reason for this change
As described in the issue.



### Description of changes
Add copyTagsToSnapshot property to the DatabaseCluster Construct.


### Description of how you validated changes
Add both unit tests and integ tests.


### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@rwlxxvii rwlxxvii mentioned this issue Jun 22, 2024
Merged
@NOUIY NOUIY mentioned this issue Jun 22, 2024
Open
@kazimanzurrashid kazimanzurrashid mentioned this issue Jun 29, 2024
Open
This was referenced Jun 29, 2024
Open
Open
This was referenced Jul 12, 2024
Open
Open
This was referenced Jul 19, 2024
Open
Open
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-neptune Related Amazon Neptune effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/needs-review
Projects
None yet
Milestone
No milestone
3 participants
@mazyu36 @aws-cdk-automation @ashishdhingra