Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-rds: CDK to support default engine version for Aurora MySQL Version 3 "3.04.2" #30109

Closed
1 of 2 tasks
aashishgk7760 opened this issue May 8, 2024 · 3 comments · Fixed by #30306
Closed
1 of 2 tasks
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@aashishgk7760
Copy link

Describe the feature

Hello Team ,

Currently CDK does not show option to select the Engine version 3.04.2 [1]

[1] https://github.com/aws/aws-cdk/blob/v2.140.0/packages/aws-cdk-lib/aws-rds/lib/cluster-engine.ts

Use Case

default engine version for Aurora MySQL Version 3 "3.04.2"

Proposed Solution

Update the below class name to include "3.04.2"

export class AuroraMysqlEngineVersion {
public static readonly VER_3_04_2 = AuroraMysqlEngineVersion.builtIn_8_0('3.04.2');
}

Other Information

N/A

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.140.0

Environment details (OS name and version, etc.)

Mac OS

@aashishgk7760 aashishgk7760 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 8, 2024
@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label May 8, 2024
@ashishdhingra ashishdhingra self-assigned this May 8, 2024
@ashishdhingra ashishdhingra added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels May 8, 2024
@ashishdhingra
Copy link
Contributor

The feature request appears to be valid. Per Database engine updates for Amazon Aurora MySQL version 3, version 3.04.2 appears to be default version when instance is created using AWS console.

@aashishgk7760 Feel free to contribute PR for this change.

Thanks,
Ashish

@ashishdhingra ashishdhingra added p2 effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels May 8, 2024
@ashishdhingra ashishdhingra removed their assignment May 14, 2024
@mergify mergify bot closed this as completed in #30306 May 24, 2024
mergify bot pushed a commit that referenced this issue May 24, 2024
….2" (#30306)

### Issue # (if applicable)

Closes #30109 

### Reason for this change


Currently CDK does not show option to select the Engine version `3.04.2`


### Description of changes


Update the below class name to include "3.04.2"

```ts
export class AuroraMysqlEngineVersion {
public static readonly VER_3_04_2 = AuroraMysqlEngineVersion.builtIn_8_0('3.04.2');
}

```

### Description of how you validated changes


unit and integration tests

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

atanaspam pushed a commit to atanaspam/aws-cdk that referenced this issue Jun 3, 2024
….2" (aws#30306)

### Issue # (if applicable)

Closes aws#30109 

### Reason for this change


Currently CDK does not show option to select the Engine version `3.04.2`


### Description of changes


Update the below class name to include "3.04.2"

```ts
export class AuroraMysqlEngineVersion {
public static readonly VER_3_04_2 = AuroraMysqlEngineVersion.builtIn_8_0('3.04.2');
}

```

### Description of how you validated changes


unit and integration tests

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)
vdahlberg pushed a commit to vdahlberg/aws-cdk that referenced this issue Jun 10, 2024
….2" (aws#30306)

### Issue # (if applicable)

Closes aws#30109 

### Reason for this change


Currently CDK does not show option to select the Engine version `3.04.2`


### Description of changes


Update the below class name to include "3.04.2"

```ts
export class AuroraMysqlEngineVersion {
public static readonly VER_3_04_2 = AuroraMysqlEngineVersion.builtIn_8_0('3.04.2');
}

```

### Description of how you validated changes


unit and integration tests

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants