EC2: Security Groups lookup by Owner

[eschirle]

Describe the feature

SecurityGroup.fromLookupByName() provides an option for looking up a security group by name - but this fails if multiple SGs are found with the provided name.

This feature is for the ability to filter security groups by Owner as well.

Use Case

I have a use case where I'd like to use a Baseline SecurityGroup for Lambda Functions that are a part of a custom construct to avoid creating a new SG and using up more Hyperplane ENIs. I can lookup by name "BaselineSecurityGroup", but my VPC is shared across multiple micro accounts, and so multiple SecurityGroups are returned.

This feature would include the option to filter SecurityGroups by SecurityGroupName and Owner, so that I can grab the SG when there are multiple with the same name in a single VPC.

Proposed Solution

Either adding an optional owner input to fromLookupByName or add a new method fromLookupByNameAndOwner in security-group.ts

public static fromLookupByName(scope: Construct, id: string, securityGroupName: string, vpc: IVpc, owner?: string) { return this.fromLookupAttributes(scope, id, { securityGroupName, vpc, owner }); }

Other Information

No response

Acknowledgements

• I may be able to implement this feature request
• This feature might incur a breaking change

CDK version used

2.142.0

Environment details (OS name and version, etc.)

N/A

[eschirle]

I created a PR with a possible solution for this #30334

[khushail]

@eschirle , this makes sense to me. Thanks for reporting and volunteering for PR contribution !

[eschirle]

@eschirle , this makes sense to me. Thanks for reporting and volunteering for PR contribution !

Hi @khushail - I made some updates to the PR today and marked it as ready for review. I was able to run unit tests and integration tests in my development environment but I think it needs some additional changes to pass validation.
Could you please take a look?

[khushail]

@eschirle , thanks for your contribution. Usually community PRs ar first reviewed by approved community reviewers and then by Core CDK Team and you could also ask for help in the mentioned slack channel in this doc. Here are the approved guidelines.

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.