Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logs: enable distribution setting on subscription filter #30422

Closed
1 of 2 tasks
mazyu36 opened this issue Jun 1, 2024 · 2 comments · Fixed by #30423 · 4 remaining pull requests
Closed
1 of 2 tasks

logs: enable distribution setting on subscription filter #30422

mazyu36 opened this issue Jun 1, 2024 · 2 comments · Fixed by #30423 · 4 remaining pull requests
Labels
@aws-cdk/aws-logs Related to Amazon CloudWatch Logs effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@mazyu36
Copy link
Contributor

mazyu36 commented Jun 1, 2024

Describe the feature

By setting distribution property in L1 Construct, You can choose the method used to distribute log data to the destination, which can be either random or grouped by log stream.

However, the L2 Construct does not support this feature.

This property is only applicable when the destination is an Amazon Kinesis data stream.

Use Case

When you want to distribute log data randomly to Kinesis Data Stream.

Proposed Solution

Add distribution property to the SubscriptionFilter class.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.143.0

Environment details (OS name and version, etc.)

All
@mazyu36 mazyu36 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 1, 2024
@github-actions github-actions bot added the @aws-cdk/aws-logs Related to Amazon CloudWatch Logs label Jun 1, 2024
@mazyu36 mazyu36 mentioned this issue Jun 1, 2024
Merged
1 task
@github-actions github-actions bot mentioned this issue Jun 3, 2024
Closed
@khushail khushail added the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Jun 3, 2024
@khushail khushail self-assigned this Jun 3, 2024
@mergify mergify bot closed this as completed in #30423 Jun 3, 2024
mergify bot pushed a commit that referenced this issue Jun 3, 2024
@mazyu36
feat(logs): add distribution property to the Subscription class (#30423)
0e95bf0 
### Issue # (if applicable)

Closes #30422

### Reason for this change
Missing Property in the Subscription class.



### Description of changes
Add destination property to the Subscription class.



### Description of how you validated changes
Add unit tests and integ tests.



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@khushail khushail removed the needs-triage This issue or PR still needs to be triaged. label Jun 3, 2024
@khushail khushail removed their assignment Jun 3, 2024
@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Jun 3, 2024
vdahlberg pushed a commit to vdahlberg/aws-cdk that referenced this issue Jun 10, 2024
@mazyu36
feat(logs): add distribution property to the Subscription class (aws#…
52d4f00 
…30423)

### Issue # (if applicable)

Closes aws#30422

### Reason for this change
Missing Property in the Subscription class.



### Description of changes
Add destination property to the Subscription class.



### Description of how you validated changes
Add unit tests and integ tests.



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Leo10Gama pushed a commit to Leo10Gama/aws-cdk that referenced this issue Jun 11, 2024
@mazyu36
feat(logs): add distribution property to the Subscription class (aws#…
995d239 
…30423)

### Issue # (if applicable)

Closes aws#30422

### Reason for this change
Missing Property in the Subscription class.



### Description of changes
Add destination property to the Subscription class.



### Description of how you validated changes
Add unit tests and integ tests.



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mazyu36 added a commit to mazyu36/aws-cdk that referenced this issue Jun 22, 2024
@mazyu36
feat(logs): add distribution property to the Subscription class (aws#…
9a47ad5 
…30423)

### Issue # (if applicable)

Closes aws#30422

### Reason for this change
Missing Property in the Subscription class.



### Description of changes
Add destination property to the Subscription class.



### Description of how you validated changes
Add unit tests and integ tests.



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@kazimanzurrashid kazimanzurrashid mentioned this issue Jun 29, 2024
Open
@NOUIY NOUIY mentioned this issue Jun 29, 2024
Open
@github-actions github-actions bot mentioned this issue Jul 1, 2024
Closed
This was referenced Jul 5, 2024
Open
Open
This was referenced Jul 16, 2024
Open
Open
@NOUIY NOUIY mentioned this issue Jul 23, 2024
Open
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-logs Related to Amazon CloudWatch Logs effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
3 participants
@mazyu36 @aws-cdk-automation @khushail