Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events: support dead letter queue for the event bus #30531

Closed
2 tasks
mazyu36 opened this issue Jun 12, 2024 · 2 comments · Fixed by #30628
Closed
2 tasks

events: support dead letter queue for the event bus #30531

mazyu36 opened this issue Jun 12, 2024 · 2 comments · Fixed by #30628
Labels
@aws-cdk/aws-events Related to CloudWatch Events effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p3

Comments

@mazyu36
Copy link
Contributor

mazyu36 commented Jun 12, 2024 •
edited
Loading

Describe the feature

Event bus support the Dead Letter Queue.

But current EventBus Class does not support it.

Use Case

To avoid losing events after they fail to be delivered to a target.

Proposed Solution

Add queue property to set the Dead Letter Queue.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.143.0

Environment details (OS name and version, etc.)

all
@mazyu36 mazyu36 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 12, 2024
@github-actions github-actions bot added the @aws-cdk/aws-events Related to CloudWatch Events label Jun 12, 2024
@mazyu36 mazyu36 changed the title events: support Dead Letter Queue for the event bus events: support dead letter queue for the event bus Jun 12, 2024
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Jun 12, 2024
@khushail
Copy link
Contributor

Thanks @mazyu36 for submitting this Feature request and volunteering for contribution!

@khushail khushail added p3 effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Jun 12, 2024
@github-actions github-actions bot mentioned this issue Jun 17, 2024
Closed
@badmintoncryer badmintoncryer mentioned this issue Jun 23, 2024
Merged
1 task
@github-actions github-actions bot mentioned this issue Jul 1, 2024
Closed
@mergify mergify bot closed this as completed in #30628 Oct 19, 2024
mergify bot pushed a commit that referenced this issue Oct 19, 2024
@badmintoncryer
feat(events): dead letter queue for an Event Bus (#30628)
318eae6 
### Issue # (if applicable)

Closes #30531.

### Reason for this change

EventBus L2 construct doesn't support for configuring dead letter queue.

### Description of changes

Add `deadLetterQueue` prop to `EventBusProps`

### Description of how you validated changes

Add both unit and integ test

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-events Related to CloudWatch Events effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(events): dead letter queue for an Event Bus badmintoncryer/aws-cdk
2 participants
@mazyu36 @khushail