aws-cdk-lib/aws-lambda: Add allowAllIpv6Outbound option to lambda function props #30994
Closed
2 tasks
Assignees
Labels
@aws-cdk/aws-lambda
Related to AWS Lambda
effort/small
Small work item – less than a day of effort
feature-request
A feature should be added or improved.
p2
Comments
mawallace
added
feature-request
ashishdhingra
added
investigating
|
SecurityGroupProps supports |
ashishdhingra
added
effort/small
1 task
This was referenced Aug 5, 2024
|
Comments on closed issues and PRs are hard for our team to see. |
1 similar comment
|
Comments on closed issues and PRs are hard for our team to see. |
pahud
pushed a commit
to pahud/aws-cdk
that referenced
this issue
Sep 9, 2024
…ons (aws#31013) ### Issue # (if applicable) Closes aws#30994. ### Reason for this change [SecurityGroupProps](https://github.com/aws/aws-cdk/blob/9295a85a8fb893d7f5eae06108b68df864096c4c/packages/aws-cdk-lib/aws-ec2/lib/security-group.ts#L272) supports `allowAllIpv6Outbound` property. The existing Lambda [FunctionOptions](https://github.com/aws/aws-cdk/blob/9295a85a8fb893d7f5eae06108b68df864096c4c/packages/aws-cdk-lib/aws-lambda/lib/function.ts#L146C18-L146C33) only supports [allowAllOutbound](https://github.com/aws/aws-cdk/blob/9295a85a8fb893d7f5eae06108b68df864096c4c/packages/aws-cdk-lib/aws-lambda/lib/function.ts#L296C12-L296C28), which is used in [configureVpc()](https://github.com/aws/aws-cdk/blob/9295a85a8fb893d7f5eae06108b68df864096c4c/packages/aws-cdk-lib/aws-lambda/lib/function.ts#L1464C11-L1464C23) while creating a new `SecurityGroup` [here](https://github.com/aws/aws-cdk/blob/9295a85a8fb893d7f5eae06108b68df864096c4c/packages/aws-cdk-lib/aws-lambda/lib/function.ts#L1503). ### Description of changes Added new property `allowAllIpv6Outbound` to `FunctionOptions`. ### Description of how you validated changes Added unit and integration tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
xazhao
pushed a commit
to xazhao/aws-cdk
that referenced
this issue
Sep 12, 2024
…ons (aws#31013) ### Issue # (if applicable) Closes aws#30994. ### Reason for this change [SecurityGroupProps](https://github.com/aws/aws-cdk/blob/9295a85a8fb893d7f5eae06108b68df864096c4c/packages/aws-cdk-lib/aws-ec2/lib/security-group.ts#L272) supports `allowAllIpv6Outbound` property. The existing Lambda [FunctionOptions](https://github.com/aws/aws-cdk/blob/9295a85a8fb893d7f5eae06108b68df864096c4c/packages/aws-cdk-lib/aws-lambda/lib/function.ts#L146C18-L146C33) only supports [allowAllOutbound](https://github.com/aws/aws-cdk/blob/9295a85a8fb893d7f5eae06108b68df864096c4c/packages/aws-cdk-lib/aws-lambda/lib/function.ts#L296C12-L296C28), which is used in [configureVpc()](https://github.com/aws/aws-cdk/blob/9295a85a8fb893d7f5eae06108b68df864096c4c/packages/aws-cdk-lib/aws-lambda/lib/function.ts#L1464C11-L1464C23) while creating a new `SecurityGroup` [here](https://github.com/aws/aws-cdk/blob/9295a85a8fb893d7f5eae06108b68df864096c4c/packages/aws-cdk-lib/aws-lambda/lib/function.ts#L1503). ### Description of changes Added new property `allowAllIpv6Outbound` to `FunctionOptions`. ### Description of how you validated changes Added unit and integration tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the feature
There is already an
allowAllOutboundoption. It confused my that this did not actually allow all outbound (only all IPv4 outbound), given that there was no corresponding IPv6 option. I think adding the option would make this more clear. It would also mirror the options on security group props.Use Case
It's nice to be able to define a lambda function without explicitly setting up security groups. This option would allow me to do this when I need to allow outbound IPv6 traffic.
Proposed Solution
It looks like we'd just need to pipe this option through to the security group that gets created (it's already an option on security groups).
Other Information
No response
Acknowledgements
CDK version used
3.616
Environment details (OS name and version, etc.)
Ubuntu 22.04.4
The text was updated successfully, but these errors were encountered: