aws-eks: manage nodegroups GPU instance types not up to date #31347
Labels
@aws-cdk/aws-eks
Related to Amazon Elastic Kubernetes Service
bug
This issue is a bug.
effort/small
Small work item – less than a day of effort
p2
Describe the bug
As a AWS CDK user for EKS, I want build out a managed node group with a mix of G5/G6/G6e instance types.
This is not possible with the current
isGpuInstanceType
check for managed node groups (here | architecture mapping here). When I specify instance types of both G5 and G6, I receive an error ofinstanceTypes of different architectures is not allowed
due to G6/G6e not existing in theknownGpuInstanceTypes
.Additionally, there is currently no instance class setup currently in the EC2 package for
G6e
instances: https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-ec2/lib/instance-types.tsRegression Issue
Last Known Working CDK Version
No response
Expected Behavior
I expect to be able to build a managed node group with both G5/G6/G6e instance classes due to the architectures being compatible.
Current Behavior
The error
'instanceTypes of different architectures is not allowed
is being thrown.I cannot reference a G6e instance class.
Reproduction Steps
Create a managed node group with instance types from a mix of G5/G6 instance families and will see the error above.
Try to reference the G6e instance class - it does not exist.
Possible Solution
To fix the G5/G6 issue:
InstanceClass.G6
to the list ofknowGpuInstanceTypes
: https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-eks/lib/managed-nodegroup.ts#L607To enable G6e instance types and get those compatible as recognized GPU instance types:
InstanceClass.G6E
to the list ofknowGpuInstanceTypes
: https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-eks/lib/managed-nodegroup.ts#L607Additional Information/Context
Happy to open a PR to handle this - just wanted to get the discussion going
CDK CLI Version
2.156.0
Framework Version
No response
Node.js Version
20.17.0
OS
macOS 14.6.1
Language
TypeScript
Language Version
Version 5.5.4
Other information
No response
The text was updated successfully, but these errors were encountered: