-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eks): update nodegroup gpu check #31445
base: main
Are you sure you want to change the base?
feat(eks): update nodegroup gpu check #31445
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR @AlexKaracaoglu - I think adding an Integ test or modifying and existing one to use this new Instance Type would be nice to confirm that it successfully deploys.
Also, can you add a unit test for the isGpuInstanceType
function?
Not sure if you are still on it but you can refer to this commit I made |
@pahud @sumupitchayan - Appreciate the follow ups, I'll get some changes in later today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AlexKaracaoglu, as mentioned by Sumu, could you use the new instance types in an existing integ test? You can refer to this PR for reference: #27373. I can also help to run the integ test if needed once you add the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Hey @paulhcsun - I appreciate the follow up. I added some changes to the integration tests to support the gpu nodegroup case. I am able to partly run the integ tests but cannot perform a real deployment - would you be able to assist me with running/getting the snapshots updated now that the changes are in? |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
Comments on closed issues and PRs are hard for our team to see. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Hi @AlexKaracaoglu, apologies for letting this PR drop, I totally missed your comment. I've re-opened the PR and added the I was able to run the integ tests successfully but I'm not able to push the changes through your fork because I do not have access rights to the libertymutual fork. Is it possible to temporarily grant me access so that I can push the updated snapshots? |
Issue # (if applicable)
Closes #31347.
Reason for this change
The motivating bug is that you cannot add a combo of g5 and a g6 as instance classes onto the same node group or else the following error will be thrown:
instanceTypes of different architectures is not allowed
.Description of changes
isGpuInstanceType
checkDescription of how you validated changes
Wrote unit tests for the
isGpuInstanceType
functionChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license