-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impossible to generate correct parameter overrides #566
Comments
@rix0rrr is actually working on a nifty utility function in #518 ( |
rix0rrr
pushed a commit
that referenced
this issue
Aug 15, 2018
ParameterOverrides needs to be a JSON-encoded object, not an object itself. Fixes #566.
rix0rrr
added a commit
that referenced
this issue
Aug 15, 2018
ParameterOverrides needs to be a JSON-encoded object, not an object itself. Fixes #566.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(TIL enter creates the issue! - actual issue incoming)
When creating a code pipeline with a CloudFormation action - we have a handy prop called
paramterOverrides
which takes{ [name: string]: any };
. Customers would use this to feed parameter configuration to a CloudFormation action when not using a template configuration file.The correct configuration for this value is a JSON object (string):
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/continuous-delivery-codepipeline-action-reference.html
(Shamelessly stolen from this example: https://github.com/quarryman/AWSfrontendCI/blob/2dab0c0e4424258f9c5864885d5dfc6498dd080b/serverless-pipeline.yaml#L217 )
However, we generate an object:
I believe we just need to call
JSON.stringify()
the passed values.The text was updated successfully, but these errors were encountered: