Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDK 0.9.0 Java init template doesn't compile #711

Closed
fulghum opened this issue Sep 13, 2018 · 0 comments · Fixed by #732
Closed

CDK 0.9.0 Java init template doesn't compile #711

fulghum opened this issue Sep 13, 2018 · 0 comments · Fixed by #732
Assignees
Labels
bug This issue is a bug.

Comments

@fulghum
Copy link
Contributor

fulghum commented Sep 13, 2018

It looks like the Java new project template was broken by some recent library changes...

~/Projects/cdk-java-init-test
❯ cdk --version
0.9.0 (build b222731)

~/Projects/cdk-java-init-test
❯ cdk init --language java
Applying project template app for java
Initializing a new git repository...
Executing mvn package...
[INFO] Scanning for projects...
[INFO] 
[INFO] --------------------< com.myorg:cdk-java-init-test >--------------------
[INFO] Building cdk-java-init-test 0.1
[INFO] --------------------------------[ jar ]---------------------------------
Downloading from central: https://repo.maven.apache.org/maven2/com/google/code/findbugs/jsr305/maven-metadata.xml
Downloaded from central: https://repo.maven.apache.org/maven2/com/google/code/findbugs/jsr305/maven-metadata.xml (461 B at 1.3 kB/s)
[INFO] 
[INFO] --- maven-dependency-plugin:2.8:build-classpath (build-classpath) @ cdk-java-init-test ---
[INFO] Wrote classpath file '/Users/fulghum/Projects/cdk-java-init-test/.classpath.txt'.
[INFO] 
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ cdk-java-init-test ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory /Users/fulghum/Projects/cdk-java-init-test/src/main/resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @ cdk-java-init-test ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 4 source files to /Users/fulghum/Projects/cdk-java-init-test/target/classes
[INFO] /Users/fulghum/Projects/cdk-java-init-test/src/main/java/com/myorg/HelloConstruct.java: /Users/fulghum/Projects/cdk-java-init-test/src/main/java/com/myorg/HelloConstruct.java uses or overrides a deprecated API.
[INFO] /Users/fulghum/Projects/cdk-java-init-test/src/main/java/com/myorg/HelloConstruct.java: Recompile with -Xlint:deprecation for details.
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /Users/fulghum/Projects/cdk-java-init-test/src/main/java/com/myorg/HelloConstruct.java:[20,25] no suitable constructor found for Bucket(com.myorg.HelloConstruct,java.lang.String)
    constructor software.amazon.awscdk.services.s3.Bucket.Bucket(software.amazon.jsii.JsiiObject.InitializationMode) is not applicable
      (actual and formal argument lists differ in length)
    constructor software.amazon.awscdk.services.s3.Bucket.Bucket(software.amazon.awscdk.Construct,java.lang.String,software.amazon.awscdk.services.s3.BucketProps) is not applicable
      (actual and formal argument lists differ in length)
[ERROR] /Users/fulghum/Projects/cdk-java-init-test/src/main/java/com/myorg/HelloConstruct.java:[29,31] method grantRead in class software.amazon.awscdk.services.s3.BucketRef cannot be applied to given types;
  required: software.amazon.awscdk.services.iam.IPrincipal,java.lang.Object
  found: software.amazon.awscdk.services.iam.IIdentityResource
  reason: actual and formal argument lists differ in length
[ERROR] /Users/fulghum/Projects/cdk-java-init-test/src/main/java/com/myorg/HelloStack.java:[34,21] no suitable constructor found for User(com.myorg.HelloStack,java.lang.String)
    constructor software.amazon.awscdk.services.iam.User.User(software.amazon.jsii.JsiiObject.InitializationMode) is not applicable
      (actual and formal argument lists differ in length)
    constructor software.amazon.awscdk.services.iam.User.User(software.amazon.awscdk.Construct,java.lang.String,software.amazon.awscdk.services.iam.UserProps) is not applicable
      (actual and formal argument lists differ in length)
[INFO] 3 errors 
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 3.470 s
[INFO] Finished at: 2018-09-13T13:05:23-07:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile (default-compile) on project cdk-java-init-test: Compilation failure: Compilation failure: 
[ERROR] /Users/fulghum/Projects/cdk-java-init-test/src/main/java/com/myorg/HelloConstruct.java:[20,25] no suitable constructor found for Bucket(com.myorg.HelloConstruct,java.lang.String)
[ERROR]     constructor software.amazon.awscdk.services.s3.Bucket.Bucket(software.amazon.jsii.JsiiObject.InitializationMode) is not applicable
[ERROR]       (actual and formal argument lists differ in length)
[ERROR]     constructor software.amazon.awscdk.services.s3.Bucket.Bucket(software.amazon.awscdk.Construct,java.lang.String,software.amazon.awscdk.services.s3.BucketProps) is not applicable
[ERROR]       (actual and formal argument lists differ in length)
[ERROR] /Users/fulghum/Projects/cdk-java-init-test/src/main/java/com/myorg/HelloConstruct.java:[29,31] method grantRead in class software.amazon.awscdk.services.s3.BucketRef cannot be applied to given types;
[ERROR]   required: software.amazon.awscdk.services.iam.IPrincipal,java.lang.Object
[ERROR]   found: software.amazon.awscdk.services.iam.IIdentityResource
[ERROR]   reason: actual and formal argument lists differ in length
[ERROR] /Users/fulghum/Projects/cdk-java-init-test/src/main/java/com/myorg/HelloStack.java:[34,21] no suitable constructor found for User(com.myorg.HelloStack,java.lang.String)
[ERROR]     constructor software.amazon.awscdk.services.iam.User.User(software.amazon.jsii.JsiiObject.InitializationMode) is not applicable
[ERROR]       (actual and formal argument lists differ in length)
[ERROR]     constructor software.amazon.awscdk.services.iam.User.User(software.amazon.awscdk.Construct,java.lang.String,software.amazon.awscdk.services.iam.UserProps) is not applicable
[ERROR]       (actual and formal argument lists differ in length)
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
mvn exited with status 1

~/Projects/cdk-java-init-test master 7s
❯ mvn package 
[INFO] Scanning for projects...
[INFO] 
[INFO] --------------------< com.myorg:cdk-java-init-test >--------------------
[INFO] Building cdk-java-init-test 0.1
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- maven-dependency-plugin:2.8:build-classpath (build-classpath) @ cdk-java-init-test ---
[INFO] Skipped writing classpath file '/Users/fulghum/Projects/cdk-java-init-test/.classpath.txt'.  No changes found.
[INFO] 
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ cdk-java-init-test ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory /Users/fulghum/Projects/cdk-java-init-test/src/main/resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @ cdk-java-init-test ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 4 source files to /Users/fulghum/Projects/cdk-java-init-test/target/classes
[INFO] /Users/fulghum/Projects/cdk-java-init-test/src/main/java/com/myorg/HelloConstruct.java: /Users/fulghum/Projects/cdk-java-init-test/src/main/java/com/myorg/HelloConstruct.java uses or overrides a deprecated API.
[INFO] /Users/fulghum/Projects/cdk-java-init-test/src/main/java/com/myorg/HelloConstruct.java: Recompile with -Xlint:deprecation for details.
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /Users/fulghum/Projects/cdk-java-init-test/src/main/java/com/myorg/HelloConstruct.java:[20,25] no suitable constructor found for Bucket(com.myorg.HelloConstruct,java.lang.String)
    constructor software.amazon.awscdk.services.s3.Bucket.Bucket(software.amazon.jsii.JsiiObject.InitializationMode) is not applicable
      (actual and formal argument lists differ in length)
    constructor software.amazon.awscdk.services.s3.Bucket.Bucket(software.amazon.awscdk.Construct,java.lang.String,software.amazon.awscdk.services.s3.BucketProps) is not applicable
      (actual and formal argument lists differ in length)
[ERROR] /Users/fulghum/Projects/cdk-java-init-test/src/main/java/com/myorg/HelloConstruct.java:[29,31] method grantRead in class software.amazon.awscdk.services.s3.BucketRef cannot be applied to given types;
  required: software.amazon.awscdk.services.iam.IPrincipal,java.lang.Object
  found: software.amazon.awscdk.services.iam.IIdentityResource
  reason: actual and formal argument lists differ in length
[ERROR] /Users/fulghum/Projects/cdk-java-init-test/src/main/java/com/myorg/HelloStack.java:[34,21] no suitable constructor found for User(com.myorg.HelloStack,java.lang.String)
    constructor software.amazon.awscdk.services.iam.User.User(software.amazon.jsii.JsiiObject.InitializationMode) is not applicable
      (actual and formal argument lists differ in length)
    constructor software.amazon.awscdk.services.iam.User.User(software.amazon.awscdk.Construct,java.lang.String,software.amazon.awscdk.services.iam.UserProps) is not applicable
      (actual and formal argument lists differ in length)
[INFO] 3 errors 
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2.627 s
[INFO] Finished at: 2018-09-13T13:05:53-07:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile (default-compile) on project cdk-java-init-test: Compilation failure: Compilation failure: 
[ERROR] /Users/fulghum/Projects/cdk-java-init-test/src/main/java/com/myorg/HelloConstruct.java:[20,25] no suitable constructor found for Bucket(com.myorg.HelloConstruct,java.lang.String)
[ERROR]     constructor software.amazon.awscdk.services.s3.Bucket.Bucket(software.amazon.jsii.JsiiObject.InitializationMode) is not applicable
[ERROR]       (actual and formal argument lists differ in length)
[ERROR]     constructor software.amazon.awscdk.services.s3.Bucket.Bucket(software.amazon.awscdk.Construct,java.lang.String,software.amazon.awscdk.services.s3.BucketProps) is not applicable
[ERROR]       (actual and formal argument lists differ in length)
[ERROR] /Users/fulghum/Projects/cdk-java-init-test/src/main/java/com/myorg/HelloConstruct.java:[29,31] method grantRead in class software.amazon.awscdk.services.s3.BucketRef cannot be applied to given types;
[ERROR]   required: software.amazon.awscdk.services.iam.IPrincipal,java.lang.Object
[ERROR]   found: software.amazon.awscdk.services.iam.IIdentityResource
[ERROR]   reason: actual and formal argument lists differ in length
[ERROR] /Users/fulghum/Projects/cdk-java-init-test/src/main/java/com/myorg/HelloStack.java:[34,21] no suitable constructor found for User(com.myorg.HelloStack,java.lang.String)
[ERROR]     constructor software.amazon.awscdk.services.iam.User.User(software.amazon.jsii.JsiiObject.InitializationMode) is not applicable
[ERROR]       (actual and formal argument lists differ in length)
[ERROR]     constructor software.amazon.awscdk.services.iam.User.User(software.amazon.awscdk.Construct,java.lang.String,software.amazon.awscdk.services.iam.UserProps) is not applicable
[ERROR]       (actual and formal argument lists differ in length)
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

@eladb eladb self-assigned this Sep 16, 2018
@eladb eladb added bug This issue is a bug. oncall labels Sep 16, 2018
eladb pushed a commit that referenced this issue Sep 17, 2018
Fixes #711

Seems like jsii stopped generating method overloads
which is the reason some of the method signatures
caused compilation errors.

Also, IIdentityResource was renamed to IPrincipal.

We should revisit once aws/jsii#233 is fixed.

But at least we want to make sure the init template
compiles.
eladb pushed a commit that referenced this issue Sep 17, 2018
Fixes #711

Seems like jsii stopped generating method overloads
which is the reason some of the method signatures
caused compilation errors.

Also, IIdentityResource was renamed to IPrincipal.

We should revisit once aws/jsii#233 is fixed.

But at least we want to make sure the init template
compiles.
eladb pushed a commit that referenced this issue Sep 20, 2018
__NOTICE__: This release includes a framework-wide [__breaking
change__](#712) which changes the type
of all the string resource attributes across the framework. Instead of using
strong-types that extend `cdk.Token` (such as `QueueArn`, `TopicName`, etc), we
now represent all these attributes as normal `string`s, and codify the tokens
into the string (using the feature introduced in [#168](#168)).

Furthermore, the `cdk.Arn` type has been removed. In order to format/parse ARNs,
use the static methods on `cdk.ArnUtils`.

See motivation and discussion in [#695](#695).

* **cfn2ts:** use stringified tokens for resource attributes instead of strong types ([#712](#712)) ([6508f78](6508f78)), closes [#518](#518) [#695](#695) [#744](#744)
* **aws-dynamodb:** Attribute type for keys, changes the signature of the `addPartitionKey` and `addSortKey` methods to be consistent across the board. ([#720](#720)) ([e6cc189](e6cc189))
* **aws-codebuild:** fix typo "priviledged" -> "privileged

* **assets:** cab't use multiple assets in the same stack ([#725](#725)) ([bba2e5b](bba2e5b)), closes [#706](#706)
* **aws-codebuild:** typo in BuildEnvironment "priviledged" -> "privileged     ([#734](#734)) ([72fec36](72fec36))
* **aws-ecr:** fix addToResourcePolicy ([#737](#737)) ([eadbda5](eadbda5))
* **aws-events:** ruleName can now be specified ([#726](#726)) ([a7bc5ee](a7bc5ee)), closes [#708](#708)
* **aws-lambda:** jsii use no long requires 'sourceAccount' ([#728](#728)) ([9e7d311](9e7d311)), closes [#714](#714)
* **aws-s3:** remove `policy` argument ([#730](#730)) ([a79190c](a79190c)), closes [#672](#672)
* **cdk:** "cdk init" java template is broken ([#732](#732)) ([281c083](281c083)), closes [#711](#711) [aws/jsii#233](aws/jsii#233)

* **aws-apigateway:** new API Gateway Construct Library ([#665](#665)) ([b0f3857](b0f3857))
* **aws-cdk:** detect presence of EC2 credentials ([#724](#724)) ([8e8c295](8e8c295)), closes [#702](#702) [#130](#130)
* **aws-codepipeline:** make the Stage insertion API in CodePipeline more flexible ([#460](#460)) ([d182818](d182818))
* **aws-codepipeline:** new "Pipeline#addStage" convenience method ([#647](#647)) ([25c9fa0](25c9fa0))
* **aws-rds:** add support for parameter groups ([#729](#729)) ([2541508](2541508)), closes [#719](#719)
* **docs:** add documentation for CDK toolkit plugings ([#733](#733)) ([965b918](965b918))
* **dependencies:** upgrade to [jsii 0.7.6](https://github.com/awslabs/jsii/releases/tag/v0.7.6)
eladb pushed a commit that referenced this issue Sep 20, 2018
* v0.9.2

__NOTICE__: This release includes a framework-wide [__breaking
change__](#712) which changes the type
of all the string resource attributes across the framework. Instead of using
strong-types that extend `cdk.Token` (such as `QueueArn`, `TopicName`, etc), we
now represent all these attributes as normal `string`s, and codify the tokens
into the string (using the feature introduced in [#168](#168)).

Furthermore, the `cdk.Arn` type has been removed. In order to format/parse ARNs,
use the static methods on `cdk.ArnUtils`.

See motivation and discussion in [#695](#695).

* **cfn2ts:** use stringified tokens for resource attributes instead of strong types ([#712](#712)) ([6508f78](6508f78)), closes [#518](#518) [#695](#695) [#744](#744)
* **aws-dynamodb:** Attribute type for keys, changes the signature of the `addPartitionKey` and `addSortKey` methods to be consistent across the board. ([#720](#720)) ([e6cc189](e6cc189))
* **aws-codebuild:** fix typo "priviledged" -> "privileged

* **assets:** cab't use multiple assets in the same stack ([#725](#725)) ([bba2e5b](bba2e5b)), closes [#706](#706)
* **aws-codebuild:** typo in BuildEnvironment "priviledged" -> "privileged     ([#734](#734)) ([72fec36](72fec36))
* **aws-ecr:** fix addToResourcePolicy ([#737](#737)) ([eadbda5](eadbda5))
* **aws-events:** ruleName can now be specified ([#726](#726)) ([a7bc5ee](a7bc5ee)), closes [#708](#708)
* **aws-lambda:** jsii use no long requires 'sourceAccount' ([#728](#728)) ([9e7d311](9e7d311)), closes [#714](#714)
* **aws-s3:** remove `policy` argument ([#730](#730)) ([a79190c](a79190c)), closes [#672](#672)
* **cdk:** "cdk init" java template is broken ([#732](#732)) ([281c083](281c083)), closes [#711](#711) [aws/jsii#233](aws/jsii#233)

* **aws-apigateway:** new API Gateway Construct Library ([#665](#665)) ([b0f3857](b0f3857))
* **aws-cdk:** detect presence of EC2 credentials ([#724](#724)) ([8e8c295](8e8c295)), closes [#702](#702) [#130](#130)
* **aws-codepipeline:** make the Stage insertion API in CodePipeline more flexible ([#460](#460)) ([d182818](d182818))
* **aws-codepipeline:** new "Pipeline#addStage" convenience method ([#647](#647)) ([25c9fa0](25c9fa0))
* **aws-rds:** add support for parameter groups ([#729](#729)) ([2541508](2541508)), closes [#719](#719)
* **docs:** add documentation for CDK toolkit plugings ([#733](#733)) ([965b918](965b918))
* **dependencies:** upgrade to [jsii 0.7.6](https://github.com/awslabs/jsii/releases/tag/v0.7.6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants