[aws-cdk] rds module not able to add proxy

[I2olanD]

Hey,
i'm currently trying to add a RDS proxy to my db cluster. Apparently, i get following error:
Cannot read property 'engine' of undefined.

Reproduction Steps

		const vpc = ec2.Vpc.fromLookup(myScope, 'someId', { 
			vpcId: 'vpc-id'
		});

		const securityGroup = ec2.SecurityGroup.fromSecurityGroupId(myScope, 
			'someId', 
			'securit-group-id'
		);

		const cluster = DatabaseCluster.fromDatabaseClusterAttributes(myScope, 'someId', {
			port,
			securityGroups: [securityGroup],
			clusterIdentifier: 'cluster-identifier',
			instanceIdentifiers: ['instance-identifier'],
			clusterEndpointAddress: ''writer-endpoint,
			readerEndpointAddress: 'reader-endpoint',
			instanceEndpointAddresses: ['instance endpoint']
		});

		const secret = new Secret(myScope, 'Secret');

		cluster.addProxy('testProxy', {
			borrowTimeout: cdk.Duration.seconds(30),
			maxConnectionsPercent: 50,
			secrets: [secret],
			vpc
		});

Error Log

Cannot read property 'engine' of undefined.

Environment

• **CLI Version :1.53.0
• **Framework Version: 1.53.0
• **Node.js Version: 10.19.0
• OS :
• **Language (Version): all

This is 🐛 Bug Report

[civilizeddev]

Sorry, currently not available

DatabaseCluster.fromDatabaseClusterAttributes returns IDatabaseCluster, which doesn't have engine in it.

There's no way to read engine from imported RDS instance/cluster resource at the moment.

Its' unstable that it currently rely on (this.dbCluster.node.defaultChild as CfnDBCluster).engine.

aws-cdk/packages/@aws-cdk/aws-rds/lib/proxy.ts

Lines 69 to 75 in 489eae6

	if (this.dbCluster && this.dbInstance) {
	throw new Error('Proxy cannot target both database cluster and database instance.');
	} else if (this.dbCluster) {
	engine = (this.dbCluster.node.defaultChild as CfnDBCluster).engine;
	} else if (this.dbInstance) {
	engine = (this.dbInstance.node.defaultChild as CfnDBInstance).engine;
	}

Ideas and suggestions are welcome.

[I2olanD]

Would it be possible to add the engine property to the IDatabaseCluster?

[I2olanD]

Any updates on this @civilizeddev ?

Best,

Roland

[civilizeddev]

@I2olanD I'm sorry for late response.

As for this issue, @skinny85 suggested a better solution.

[I2olanD]

hey @civilizeddev, @skinny85

figured it out :) TY!

[tvb]

@I2olanD care to elaborate how?

[aws-apradana]

Any solution for this? Im impacted with the same issue as well

[I2olanD]

hey @tvb, sorry for the super late response. I don't have access to that codebase anymore but if i remember correctly, we created a new cluster via "DatabaseClusterFromSnapshot" and added the proxy to that.