We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The IAM policy optimization code (#916) has an issue that may cause unwanted extension of permissions.
Repro:
const doc = new iam.PolicyDocument(); doc.addStatement(new iam.PolicyStatement() .addResource('bucket1') .addActions('s3:read-only')); doc.addStatement(new iam.PolicyStatement() .addResource('bucket2') .addActions('s3:*'));
Output:
{ "Version": "2012-10-17", "Statement": [ { "Effect": "Allow", "Action": "s3:*", "Resource": [ "bucket1", "bucket2" ] } ] }
Expected (obvsiouly, we didn't want full access to "bucket1"):
{ "Version": "2012-10-17", "Statement": [ { "Effect": "Allow", "Action": "s3:read-only", "Resource": "bucket1" }, { "Effect": "Allow", "Action": "s3:*", "Resource": "bucket2" } ] }
The text was updated successfully, but these errors were encountered:
I am going to revert #916 for now and we should discuss what's the right way to introduce changes in this layer.
Sorry, something went wrong.
Revert "feat(IAM): Optimize IAM policy statements for size (#916)"
e4f4679
This reverts commit 5996442. Fixes #957 Reverts #916
Revert "feat(IAM): Optimize IAM policy statements for size (#916)" (#958
5bb7c93
) This reverts commit 5996442. Fixes #957 Reverts #916
Successfully merging a pull request may close this issue.
The IAM policy optimization code (#916) has an issue that may cause unwanted extension of permissions.
Repro:
Output:
Expected (obvsiouly, we didn't want full access to "bucket1"):
The text was updated successfully, but these errors were encountered: