-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): Updated examples topic to use ECS L2 construct #1195
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
1caf425
ECS example WIP
Doug-AWS 8c8be92
ECS example WIP
Doug-AWS c6bc455
Fixed TypeScript formatting
Doug-AWS f342d3b
WIP; explained the two launch types
Doug-AWS 29dfa0b
Fixed ECS example
Doug-AWS 5cb3d90
Removed lingering Java tab
Doug-AWS 908f28a
Update examples.rst
Doug-AWS b5b3dd4
WIP on ECS example
Doug-AWS 9105f97
Update list of AWS service benefits; WIP
Doug-AWS 6b36eb7
Updated intro text for ECS example; WIP
Doug-AWS 8e783ea
Removed info about future content in examples
Doug-AWS 675b8a8
First cut at ECS example for re:Invent
Doug-AWS 0f8713b
Removed mentions of greeter service(s)
Doug-AWS 307b34a
Update examples.rst
Doug-AWS aa359ac
Updated FargateService to LoadBalancedFargateService
Doug-AWS d0e2aa2
Updated ECS example using CDK 0.19.0; removed autoscaling
Doug-AWS 34275d9
Reverted autoscaling blurb
Doug-AWS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's true. The example is not yet useful without a load balancer though, since this is a web service but you will be unable to hit the endpoints (because they'll be in a private VPC if I'm not mistaken).
Just sayin'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you planning to make this section longer, or is it the plan to publish like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add a load balancer and auto-scaling for tasks to the example. Once the new template is released, I'll fix the references:
my_ecs_construct.ts in the bin directory -> my_ecs_stack.ts in the lib directory