Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lambda-nodejs): expose more esbuild options #12063

Merged
merged 5 commits into from
Dec 15, 2020
Merged

feat(lambda-nodejs): expose more esbuild options #12063

merged 5 commits into from
Dec 15, 2020

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Dec 14, 2020

Expose logLevel and keepNames.

Closes #12046

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 14, 2020 •
edited
Loading

eladb
eladb previously approved these changes Dec 14, 2020
View reviewed changes
packages/@aws-cdk/aws-lambda-nodejs/README.md Outdated
Comment on lines 135 to 136
via properties under `bundling`: `minify`, `sourceMap`, `target`, `loader`, `logLevel` and
`keepNames`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's not necessary to list all of these here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, can you reapprove? thx.

@mergify
Copy link
Contributor

mergify bot commented Dec 14, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed eladb’s stale review December 14, 2020 09:30

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Dec 15, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 1afed92
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Dec 15, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit bab21b3 into aws:master Dec 15, 2020
flochaz pushed a commit to flochaz/aws-cdk that referenced this pull request Jan 5, 2021
@jogold @flochaz
feat(lambda-nodejs): expose more esbuild options (aws#12063)
fd24960 
Expose [`logLevel`](https://esbuild.github.io/api/#log-level) and [`keepNames`](https://esbuild.github.io/api/#keep-names).

Closes aws#12046


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees

@eladb eladb

Labels
@aws-cdk/aws-lambda-nodejs
Projects
None yet
Milestone
No milestone
3 participants
@jogold @aws-cdk-automation @eladb