feat(ec2): Support for new EBS types #12074

leandrodamascena · 2020-12-14T21:56:15Z

closes #12071

Added new EBS types released in re:Invent 2020 and fixed some documentation problems. Some observations:

./packages/@aws-cdk/aws-elasticsearch/lib/domain.ts - The Elasticsearch service allows only General Purpose, Provisioned IOPS and Magnetic.
./packages/@aws-cdk/aws-rds/lib/instance.ts - Storage types and the official link were added

For compatibility reasons, I kept the " GENERAL_PURPOSE_SSD" as GP2 and created a new type called "GENERAL_PURPOSE_SSD_GP3" for GP3. The same happened to IO1/IO2. Please let me know if it is correct, I think it is the best way to not break stacks that already exist with these definitions.

@NetaNir

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Added new EBS types released in re:Invent 2020 and fixed some documentation problems closes aws#12071

gitpod-io · 2020-12-14T21:56:23Z

leandrodamascena · 2020-12-14T22:19:08Z

PR Linter checked failed, but I don't know what I need to add to the README file. There is no section talking about EBS Types in all the packages I changed.

Please let me know and I can change. Ty.

NetaNir

Thanks for submitting it. A few comments about the docs, and lets remove all the added tests

NetaNir · 2020-12-28T18:47:56Z

packages/@aws-cdk/aws-ec2/test/volume.test.ts

@@ -338,6 +338,25 @@ nodeunitShim({
    test.done();
  },

+  'volume: io2'(test: Test) {


If there is nothing special about the volume type, there is no need to add a unit test for it. Given the large number of types, adding a test for each one will increase the overall tests execution time without providing additional value.

Okay, I'm going to remove this test and all the others! As I saw tests with specific volume types, I considered it important for the process. But it makes sense not to increase the execution time of the tests.

NetaNir · 2020-12-28T19:00:15Z

packages/@aws-cdk/aws-ec2/test/instance.test.ts

@@ -226,7 +247,7 @@ nodeunitShim({

      // THEN
      test.deepEqual(instance.node.metadata[0].type, cxschema.ArtifactMetadataEntryType.WARN);
-      test.deepEqual(instance.node.metadata[0].data, 'iops will be ignored without volumeType: EbsDeviceVolumeType.IO1');
+      test.deepEqual(instance.node.metadata[0].data, 'iops will be ignored without volumeType: EbsDeviceVolumeType.IO1 or EbsDeviceVolumeType.IO2');


This warning is confusing. From the code it seems like setting volumeType to EbsDeviceVolumeType.IO2 without setting iops is not allowed, but the warning implies the other way around?

Same comment as below, if this test is not adding any value we shouldn't add it.

If these were added to satisfy the linter rule, note that I have added an exempt label so it will not block the PR

Great! As the comment above, I'll remove this test too.

Pull request has been modified.

pr

…into feature/new-ebs-types

…ascena/aws-cdk into feature/new-ebs-types

Removed unnecessary tests. closes aws#12071

leandrodamascena · 2020-12-28T21:19:26Z

Thanks for submitting it. A few comments about the docs, and lets remove all the added tests

I removed all the added tests and committed again. Let me know if I need to change anything else.

Pull request has been modified.

Removed Trailing spaces. closes aws#12071

Pull request has been modified.

mergify · 2021-01-21T00:45:52Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2021-01-21T01:57:46Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2021-01-21T01:57:47Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
Commit ID: 4279fba
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@NetaNir

closes aws#12071 Added new EBS types released in re:Invent 2020 and fixed some documentation problems. Some observations: ./packages/@aws-cdk/aws-elasticsearch/lib/domain.ts - The Elasticsearch service allows only General Purpose, Provisioned IOPS and Magnetic. ./packages/@aws-cdk/aws-rds/lib/instance.ts - Storage types and the official link were added For compatibility reasons, I kept the " GENERAL_PURPOSE_SSD" as GP2 and created a new type called "GENERAL_PURPOSE_SSD_GP3" for GP3. The same happened to IO1/IO2. Please let me know if it is correct, I think it is the best way to not break stacks that already exist with these definitions. @NetaNir ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Fixes #12816. * add validation: must specify `iops` if `volumeType` is `io1` or `io2` * fix validation: `iops` may only be specified if the `volumeType` is `io1`, `io2` or `gp3` * fix validation: `iops` minimum & maximum for `io1`, `io2` and `gp3` respectively * fix validation: `iops` maximum ratio (IOPS/Gib) for `io1`, `io2` and `gp3` respectively * fix validation: `multi-attach` is supported exclusively on `io1` and `io2` volumes. * fix validation: `size` minimum & maximum for all `volumeType` (including `gp3` and `io2` which was a bug specified in #12816) Unit tests are either added / fixed for above changes. References: #12074 https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-ebs-volume.html https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ebs-volume-types.html ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Fixes aws#12816. * add validation: must specify `iops` if `volumeType` is `io1` or `io2` * fix validation: `iops` may only be specified if the `volumeType` is `io1`, `io2` or `gp3` * fix validation: `iops` minimum & maximum for `io1`, `io2` and `gp3` respectively * fix validation: `iops` maximum ratio (IOPS/Gib) for `io1`, `io2` and `gp3` respectively * fix validation: `multi-attach` is supported exclusively on `io1` and `io2` volumes. * fix validation: `size` minimum & maximum for all `volumeType` (including `gp3` and `io2` which was a bug specified in aws#12816) Unit tests are either added / fixed for above changes. References: aws#12074 https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-ebs-volume.html https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ebs-volume-types.html ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

feat(ec2): Support for new EBS types

ffef11e

Added new EBS types released in re:Invent 2020 and fixed some documentation problems closes aws#12071

github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Dec 14, 2020

github-actions bot assigned rix0rrr Dec 14, 2020

NetaNir added the pr-linter/exempt-readme The PR linter will not require README changes label Dec 14, 2020

leandrodamascena added 2 commits December 15, 2020 09:11

Merge branch 'master' into feature/new-ebs-types

bf924f8

Merge branch 'master' into feature/new-ebs-types

8614ac4

NetaNir self-assigned this Dec 27, 2020

NetaNir previously requested changes Dec 28, 2020

View reviewed changes

NetaNir added the pr-linter/exempt-test The PR linter will not require test changes label Dec 28, 2020

Merge branch 'master' into feature/new-ebs-types

c2f20a9

leandrodamascena added 4 commits December 28, 2020 21:04

Merge pull request #1 from aws/master

baa39d6

pr

Merge branch 'master' of https://github.com/leandrodamascena/aws-cdk …

e64ca4c

…into feature/new-ebs-types

Merge branch 'feature/new-ebs-types' of https://github.com/leandrodam…

f21617b

…ascena/aws-cdk into feature/new-ebs-types

feat(ec2): Support for new EBS types

d3ccef6

Removed unnecessary tests. closes aws#12071

Merge branch 'master' into feature/new-ebs-types

d2a10da

rix0rrr previously approved these changes Jan 6, 2021

View reviewed changes

Merge branch 'master' into feature/new-ebs-types

ab1edf3

NetaNir previously approved these changes Jan 20, 2021

View reviewed changes

NetaNir mentioned this pull request Jan 20, 2021

(ec2): Support for new EBS types released in re:Invent 2020. #12071

Closed

2 tasks

feat(ec2): Support for new EBS types

9ecf7b1

Removed Trailing spaces. closes aws#12071

Merge branch 'master' into feature/new-ebs-types

0fd879d

NetaNir approved these changes Jan 21, 2021

View reviewed changes

Merge branch 'master' into feature/new-ebs-types

4279fba

mergify bot merged commit 6a2ce55 into aws:master Jan 21, 2021

This was referenced Jan 22, 2021

[ec2] add gp3 support to EbsDeviceVolumeType #12020

Closed

(ec2): io2 support - Cfn Supports natively but CDK does not #12052

Closed

kirintwn mentioned this pull request Feb 2, 2021

fix(ec2): volume props validations are incorrect #12821

Merged

peterwoodworth mentioned this pull request Aug 13, 2021

fix(autoscaling): EbsDeviceVolumeType.IO2 is not a valid CloudFormation value #16028

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ec2): Support for new EBS types #12074

feat(ec2): Support for new EBS types #12074

leandrodamascena commented Dec 14, 2020

gitpod-io bot commented Dec 14, 2020 •

edited

Loading

leandrodamascena commented Dec 14, 2020

NetaNir left a comment

NetaNir Dec 28, 2020

leandrodamascena Dec 28, 2020

NetaNir Dec 28, 2020

leandrodamascena Dec 28, 2020

leandrodamascena commented Dec 28, 2020

mergify bot commented Jan 21, 2021

mergify bot commented Jan 21, 2021

aws-cdk-automation commented Jan 21, 2021

feat(ec2): Support for new EBS types #12074

feat(ec2): Support for new EBS types #12074

Conversation

leandrodamascena commented Dec 14, 2020

@NetaNir

gitpod-io bot commented Dec 14, 2020 • edited Loading

leandrodamascena commented Dec 14, 2020

NetaNir left a comment

Choose a reason for hiding this comment

NetaNir Dec 28, 2020

Choose a reason for hiding this comment

leandrodamascena Dec 28, 2020

Choose a reason for hiding this comment

NetaNir Dec 28, 2020

Choose a reason for hiding this comment

leandrodamascena Dec 28, 2020

Choose a reason for hiding this comment

leandrodamascena commented Dec 28, 2020

mergify bot commented Jan 21, 2021

mergify bot commented Jan 21, 2021

aws-cdk-automation commented Jan 21, 2021

AWS CodeBuild CI Report

gitpod-io bot commented Dec 14, 2020 •

edited

Loading