Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(codepipeline-actions): use codebuild batch iam permissions when executeBatchBuild: true #12181

Merged
merged 13 commits into from
Dec 24, 2020
Merged

fix(codepipeline-actions): use codebuild batch iam permissions when executeBatchBuild: true #12181

merged 13 commits into from
Dec 24, 2020

Conversation

tjenkinson
Copy link
Contributor

@tjenkinson tjenkinson commented Dec 21, 2020 •
edited
Loading

If the executeBatchBuild prop is added to trigger a batch build, we also need to switch the IAM permissions to the ones which allow triggering a batch build. This does that.

This should probably have been part of #11741

@gitpod-io
Copy link

gitpod-io bot commented Dec 21, 2020 •
edited
Loading

@tjenkinson tjenkinson changed the title use codebuild batch iam permissions when executeBatchBuild: true fix(codebuild): use codebuild batch iam permissions when executeBatchBuild: true Dec 21, 2020
@github-actions github-actions bot added the @aws-cdk/aws-codebuild Related to AWS CodeBuild label Dec 21, 2020
@tjenkinson tjenkinson changed the title fix(codebuild): use codebuild batch iam permissions when executeBatchBuild: true fix(codepipeline-actions): use codebuild batch iam permissions when executeBatchBuild: true Dec 21, 2020
@mergify
Copy link
Contributor

mergify bot commented Dec 21, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@tjenkinson tjenkinson marked this pull request as ready for review December 21, 2020 22:33
@tjenkinson
Copy link
Contributor Author

@skinny85 I think the last commit is also going to fail because a lot more expectations will need updating. I'm wondering if I should

  • update the other expectations or
  • go back to commit dbfaa27 and have the duplication of codebuild:BatchGetBuilds or
  • just always add all of codebuild:StartBuild, codebuild:StopBuild, codebuild:StartBuildBatch, codebuild:StopBuildBatch, even when a batch build is not configured

Thoughts?

skinny85
skinny85 previously requested changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @tjenkinson !

Added my suggestion on how to make it easier to not modify the existing tests.

.../@aws-cdk/aws-codepipeline-actions/test/integ.pipeline-code-build-multiple-inputs-outputs.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-codepipeline-actions/lib/codebuild/build-action.ts Show resolved Hide resolved
@mergify mergify bot dismissed skinny85’s stale review December 23, 2020 21:47

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 9a156b2
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

skinny85
skinny85 approved these changes Dec 24, 2020
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @tjenkinson !

@mergify
Copy link
Contributor

mergify bot commented Dec 24, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Dec 24, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5279f37 into aws:master Dec 24, 2020
flochaz pushed a commit to flochaz/aws-cdk that referenced this pull request Jan 5, 2021
@tjenkinson @flochaz
fix(codepipeline-actions): use codebuild batch iam permissions when `…
b5a3338 
…executeBatchBuild: true` (aws#12181)

If the `executeBatchBuild` prop is added to trigger a batch build, we also need to switch the IAM permissions to the ones which allow triggering a batch build. This does that.

This should probably have been part of aws#11741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skinny85 skinny85 skinny85 approved these changes

Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild @aws-cdk/aws-codepipeline-actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tjenkinson @aws-cdk-automation @skinny85