chore(s3-deployment): restore lambda tests #12220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change in #12129 accidentally deleted the unit tests for the s3-deployment lambda function. This change restores them. In order to allow tests to stub the `aws` CLI, I've added an environment variable TEST_AWSCLI_PATH. If it is defined, it will be determine the path to the CLI. Otherwise, `/opt/awscli/aws` will be used.
|
|
iliapolo
reviewed
Dec 24, 2020
iliapolo
reviewed
Dec 24, 2020
iliapolo
reviewed
Dec 24, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
iliapolo
approved these changes
Dec 24, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
flochaz
pushed a commit
to flochaz/aws-cdk
that referenced
this pull request
Jan 5, 2021
The change in aws#12129 accidentally deleted the unit tests for the s3-deployment lambda function. This change restores them. Since tests are written in python, run them inside a docker image derived from public.ecr.aws/lambda/python. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in #12129 accidentally deleted the unit tests for the s3-deployment lambda function. This change restores them.
Since tests are written in python, run them inside a docker image derived from public.ecr.aws/lambda/python.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license