Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aws-cdk): be aware of IAM and SecurityGroup changes #1240

Merged
merged 27 commits into from
Dec 10, 2018
Merged

feat(aws-cdk): be aware of IAM and SecurityGroup changes #1240

merged 27 commits into from
Dec 10, 2018

Commits on Nov 22, 2018

  1. WIP

    @rix0rrr
    Rico Huijbers authored and rix0rrr committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    cf38263 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2018

  1. feat(aws-cdk): be aware of IAM and SecurityGroup changes 

    Add awareness of potentially risky permissions changes to the
cfnspec and diff tool, and surface those changes in an easily
digestible format.

This is an initial commit.

Feature TODO:

- [ ] Recognize AWS::Lambda::Permission objects
- [ ] Recognize managed policies
- [ ] Add support for SecurityGroup rules
- [ ] Reverse engineer construct paths from logical IDs
- [ ] Apply same logic to format inline diffs for IAM policy
  property updates.
- [ ] Automatically diff and confirm statement additions on every
  'deploy'.

Quality TODO:

- [ ] property tests on statement equality, parsing
- [ ] tests on 'uncfn' routines
- [ ] Replace CLI table library in aws-cdk to be the same as
  this one (supports newlines in cells and generally looks better).

Fixes #978.
    @rix0rrr
    rix0rrr committed Nov 23, 2018
    Configuration menu
    Copy the full SHA
    88bb447 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2018

  1. Recognize Lambda::Permissions objects

    @rix0rrr
    rix0rrr committed Nov 26, 2018
    Configuration menu
    Copy the full SHA
    81ee604 View commit details
    Browse the repository at this point in the history

  2. Make Condition representation more compact

    @rix0rrr
    rix0rrr committed Nov 26, 2018
    Configuration menu
    Copy the full SHA
    b403e1c View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2018

  1. Recognize and list managed policies as well

    @rix0rrr
    rix0rrr committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    7fa16c7 View commit details
    Browse the repository at this point in the history

  2. Recognize and list managed policies as well

    @rix0rrr
    rix0rrr committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    27bc21e View commit details
    Browse the repository at this point in the history

  3. This file is not necessary

    @rix0rrr
    rix0rrr committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    1899e6a View commit details
    Browse the repository at this point in the history

  4. Make loading of specification.json lazy 

    Before, the json file would be loaded upon initialization of the
library, but the library would also be loaded in the build tool.

It's only because of some crazy lazy evaluation optimization done
by NodeJS that that didn't blow up before, but due to code changes it
does blow up now.
    @rix0rrr
    rix0rrr committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    9366966 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'huijbers/iam-aware-diffs' of github.com:awslabs/aws-cdk… 

    … into huijbers/iam-aware-diffs
    @rix0rrr
    rix0rrr committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    cce4b3e View commit details
    Browse the repository at this point in the history

  6. Translate logical IDs to construct paths if possible

    @rix0rrr
    rix0rrr committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    6bcf9a9 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2018

  1. Add support for surfacing Security Group changes

    @rix0rrr
    rix0rrr committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    bb87db2 View commit details
    Browse the repository at this point in the history

  2. Prompt for confirmation during deployments

    @rix0rrr
    rix0rrr committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    dce1152 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2018

  1. Add tests on IAM, fix bugs found

    @rix0rrr
    rix0rrr committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    b239852 View commit details
    Browse the repository at this point in the history

  2. Don't call resourceType when the type has changed

    @rix0rrr
    rix0rrr committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    68c34d3 View commit details
    Browse the repository at this point in the history

  3. Add test on on-role policies

    @rix0rrr
    rix0rrr committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    7e78061 View commit details
    Browse the repository at this point in the history

  4. Add tests on security group rules

    @rix0rrr
    rix0rrr committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    f35d076 View commit details
    Browse the repository at this point in the history

  5. Replace tables library in toolkit

    @rix0rrr
    rix0rrr committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    c3f9557 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2018

  1. Fix syntax for renderTable()

    @rix0rrr
    rix0rrr committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    ec11d79 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into huijbers/iam-aware-… 

    …diffs
    @rix0rrr
    rix0rrr committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    20f4a9d View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2018

  1. Add toolkit integ test

    @rix0rrr
    rix0rrr committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    e2cc62a View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into huijbers/iam-aware-… 

    …diffs
    @rix0rrr
    rix0rrr committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    295b518 View commit details
    Browse the repository at this point in the history

  3. WIP

    @rix0rrr
    rix0rrr committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    c9eb12e View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into huijbers/iam-aware-… 

    …diffs
    @rix0rrr
    rix0rrr committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    c5205ee View commit details
    Browse the repository at this point in the history

  5. Incorporate review comments

    @rix0rrr
    rix0rrr committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    86c4287 View commit details
    Browse the repository at this point in the history

  6. Make it possible to put requireApproval in cdk.json

    @rix0rrr
    rix0rrr committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    2005ce6 View commit details
    Browse the repository at this point in the history

  7. Update diff with new expectation

    @rix0rrr
    rix0rrr committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    fc735aa View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2018

  1. Update docs

    @rix0rrr
    rix0rrr committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    92ebd32 View commit details
    Browse the repository at this point in the history