-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-cdk): be aware of IAM and SecurityGroup changes #1240
Merged
Commits on Nov 22, 2018
-
Configuration menu - View commit details
-
Copy full SHA for cf38263 - Browse repository at this point
Copy the full SHA cf38263View commit details
Commits on Nov 23, 2018
-
feat(aws-cdk): be aware of IAM and SecurityGroup changes
Add awareness of potentially risky permissions changes to the cfnspec and diff tool, and surface those changes in an easily digestible format. This is an initial commit. Feature TODO: - [ ] Recognize AWS::Lambda::Permission objects - [ ] Recognize managed policies - [ ] Add support for SecurityGroup rules - [ ] Reverse engineer construct paths from logical IDs - [ ] Apply same logic to format inline diffs for IAM policy property updates. - [ ] Automatically diff and confirm statement additions on every 'deploy'. Quality TODO: - [ ] property tests on statement equality, parsing - [ ] tests on 'uncfn' routines - [ ] Replace CLI table library in aws-cdk to be the same as this one (supports newlines in cells and generally looks better). Fixes #978.
Configuration menu - View commit details
-
Copy full SHA for 88bb447 - Browse repository at this point
Copy the full SHA 88bb447View commit details
Commits on Nov 26, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 81ee604 - Browse repository at this point
Copy the full SHA 81ee604View commit details -
Configuration menu - View commit details
-
Copy full SHA for b403e1c - Browse repository at this point
Copy the full SHA b403e1cView commit details
Commits on Nov 27, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 7fa16c7 - Browse repository at this point
Copy the full SHA 7fa16c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 27bc21e - Browse repository at this point
Copy the full SHA 27bc21eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1899e6a - Browse repository at this point
Copy the full SHA 1899e6aView commit details -
Make loading of specification.json lazy
Before, the json file would be loaded upon initialization of the library, but the library would also be loaded in the build tool. It's only because of some crazy lazy evaluation optimization done by NodeJS that that didn't blow up before, but due to code changes it does blow up now.
Configuration menu - View commit details
-
Copy full SHA for 9366966 - Browse repository at this point
Copy the full SHA 9366966View commit details -
Merge branch 'huijbers/iam-aware-diffs' of github.com:awslabs/aws-cdk…
… into huijbers/iam-aware-diffs
Configuration menu - View commit details
-
Copy full SHA for cce4b3e - Browse repository at this point
Copy the full SHA cce4b3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bcf9a9 - Browse repository at this point
Copy the full SHA 6bcf9a9View commit details
Commits on Nov 28, 2018
-
Configuration menu - View commit details
-
Copy full SHA for bb87db2 - Browse repository at this point
Copy the full SHA bb87db2View commit details -
Configuration menu - View commit details
-
Copy full SHA for dce1152 - Browse repository at this point
Copy the full SHA dce1152View commit details
Commits on Nov 30, 2018
-
Configuration menu - View commit details
-
Copy full SHA for b239852 - Browse repository at this point
Copy the full SHA b239852View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68c34d3 - Browse repository at this point
Copy the full SHA 68c34d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e78061 - Browse repository at this point
Copy the full SHA 7e78061View commit details -
Configuration menu - View commit details
-
Copy full SHA for f35d076 - Browse repository at this point
Copy the full SHA f35d076View commit details -
Configuration menu - View commit details
-
Copy full SHA for c3f9557 - Browse repository at this point
Copy the full SHA c3f9557View commit details
Commits on Dec 3, 2018
-
Configuration menu - View commit details
-
Copy full SHA for ec11d79 - Browse repository at this point
Copy the full SHA ec11d79View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20f4a9d - Browse repository at this point
Copy the full SHA 20f4a9dView commit details
Commits on Dec 6, 2018
-
Configuration menu - View commit details
-
Copy full SHA for e2cc62a - Browse repository at this point
Copy the full SHA e2cc62aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 295b518 - Browse repository at this point
Copy the full SHA 295b518View commit details -
Configuration menu - View commit details
-
Copy full SHA for c9eb12e - Browse repository at this point
Copy the full SHA c9eb12eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c5205ee - Browse repository at this point
Copy the full SHA c5205eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 86c4287 - Browse repository at this point
Copy the full SHA 86c4287View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2005ce6 - Browse repository at this point
Copy the full SHA 2005ce6View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc735aa - Browse repository at this point
Copy the full SHA fc735aaView commit details
Commits on Dec 10, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 92ebd32 - Browse repository at this point
Copy the full SHA 92ebd32View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.