Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): dockerExec does not return stdout #13271

Closed
wants to merge 1 commit into from

Conversation

bigkraig
Copy link

@bigkraig bigkraig commented Feb 24, 2021

First noticed when using BundlingDockerImage.cp, which is the only place where the stdout from dockerExec is needed.

It appears that the bug was introduced in #12001


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Feb 24, 2021

@github-actions github-actions bot added the @aws-cdk/core Related to core CDK functionality label Feb 24, 2021
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: b14dd16
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jogold
Copy link
Contributor

jogold commented Feb 25, 2021

Thanks. You are right.

The correct way to solve this is https://github.com/aws/aws-cdk/pull/12258/files#diff-fdec202251e1e1d22f9e271a2032f697659fc0374ce942b85ec8952b6fb1c425R245:

const { stdout } = dockerExec(['create', this.image], {}); // Empty options to avoid stdout redirect here

#12258 has been reverted for now but should be merged again after #13152.

@bigkraig bigkraig closed this Feb 25, 2021
@bigkraig bigkraig deleted the dockerExec-output branch February 25, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/core Related to core CDK functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants