Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): toJsonString() cannot handle list intrinsics #13544

Merged
merged 4 commits into from
Mar 16, 2021

Commits on Mar 11, 2021

  1. fix(core): toJsonString() cannot handle lists

    The previous attempt at a fix missed one important case: the types
    of the values involved in the `{ Fn::Join }` expression didn't actually
    match up. They all needed to be strings, but the previous implentation
    just dropped list-typed values in there.
    
    Unfortunately, there is no way to do it correctly with just string
    manipulation in CloudFormation (`{ Fn::Join }` etc), so we'll have
    to resort to using a Custom Resource if we encounter list values.
    
    Actually fixes #13465.
    rix0rrr committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    8b1e6d3 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. Configuration menu
    Copy the full SHA
    0bd7841 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    403513c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    79711fe View commit details
    Browse the repository at this point in the history