Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codedeploy): Use aws-cli instead of awscli for yum #13655

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

diegotry
Copy link
Contributor

Package name for yum is not awscli. This causes the command to have a return code different than 0, which fails the user-data script.

This change addresses the issue: #13654


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Package name for yum is not awscli. This causes the command to have a return code different than 0, which fails the user-data script.

This change addresses the issue: aws#13654
@gitpod-io
Copy link

gitpod-io bot commented Mar 18, 2021

@github-actions github-actions bot added @aws-cdk/aws-codedeploy Related to AWS CodeDeploy package/tools Related to AWS CDK Tools or CLI labels Mar 18, 2021
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @diegotry , thanks for the quick fix!

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 73156e2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 18, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 449ce12 into aws:master Mar 18, 2021
eladb pushed a commit that referenced this pull request Mar 24, 2021
Package name for yum is not awscli. This causes the command to have a return code different than 0, which fails the user-data script.

This change addresses the issue: #13654


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
Package name for yum is not awscli. This causes the command to have a return code different than 0, which fails the user-data script.

This change addresses the issue: aws#13654


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-codedeploy Related to AWS CodeDeploy package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants