Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change ?? to || in check-yarn-lock.js #14644

Merged
merged 2 commits into from
May 12, 2021

Conversation

skinny85
Copy link
Contributor

?? is only supported since Node 14,
but CDK should build with Node 10.

Fixes #14634


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

`??` is only supported since Node 14,
but CDK should build with Node 10.

Fixes aws#14634
@skinny85 skinny85 requested a review from njlynch May 11, 2021 21:26
@gitpod-io
Copy link

gitpod-io bot commented May 11, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 11, 2021
@mergify
Copy link
Contributor

mergify bot commented May 12, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 690cc21
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 8a9f6bb into aws:master May 12, 2021
@mergify
Copy link
Contributor

mergify bot commented May 12, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@skinny85 skinny85 deleted the chore/fix-check-yarn-lock-null-coalesce branch May 12, 2021 15:42
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
`??` is only supported since Node 14,
but CDK should build with Node 10.

Fixes aws#14634

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-cdk): automated gitpod dev setup currently fails
3 participants