Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ecs-patterns): add capacity provider strategies to queue processing service pattern #15684

Merged
merged 8 commits into from
Aug 26, 2021
Merged

feat(ecs-patterns): add capacity provider strategies to queue processing service pattern #15684

merged 8 commits into from
Aug 26, 2021

Conversation

tandfy
Copy link
Contributor

@tandfy tandfy commented Jul 21, 2021

closes #14781

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jul 21, 2021

@peterwoodworth peterwoodworth added @aws-cdk/aws-ecs-patterns Related to ecs-patterns library effort/small Small work item – less than a day of effort labels Jul 22, 2021
upparekh
upparekh previously requested changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@upparekh upparekh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tandfy , thanks for contributing! The PR looks great! Just a file deletion that needs to be addressed before we can merge it.

packages/@aws-cdk/aws-ecs-patterns/package-lock.json Outdated
Comment on lines 1 to 7
{
"name": "@aws-cdk/aws-ecs-patterns",
"version": "0.0.0",
"lockfileVersion": 1,
"requires": true,
"dependencies": {
"@aws-cdk/assets": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please delete the package-lock.json file. The yarn-lock keeps package dependencies in sync so we don't need to commit package-lock.json files for individual modules.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
I deleted package-lock.json.

@mergify mergify bot dismissed upparekh’s stale review August 23, 2021 23:53

Pull request has been modified.

upparekh
upparekh approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@upparekh upparekh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify
Copy link
Contributor

mergify bot commented Aug 26, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 25c7d5d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit f40e8d6 into aws:master Aug 26, 2021
@mergify
Copy link
Contributor

mergify bot commented Aug 26, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@tandfy @hollanddd
feat(ecs-patterns): add capacity provider strategies to queue process…
7b0f818 
…ing service pattern (aws#15684)

closes aws#14781

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Sep 6, 2021
@tandfy @TikiTDO
feat(ecs-patterns): add capacity provider strategies to queue process…
cc9830c 
…ing service pattern (aws#15684)

closes aws#14781

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
@tandfy @david-doyle-as24
feat(ecs-patterns): add capacity provider strategies to queue process…
4d46349 
…ing service pattern (aws#15684)

closes aws#14781

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upparekh upparekh upparekh approved these changes

Assignees

@uttarasridhar uttarasridhar

@SoManyHs SoManyHs

@madeline-k madeline-k

Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library effort/small Small work item – less than a day of effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-ecs-patterns): Add capacity_provider_strategies to QueueProcessingFargateService
7 participants
@tandfy @aws-cdk-automation @upparekh @uttarasridhar @SoManyHs @peterwoodworth @madeline-k