Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-stepfunctions): add support to heartbeat error inside catch block #16078

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

diegotry
Copy link
Contributor

@diegotry diegotry commented Aug 16, 2021

Step Functions recently added a feature to catch States.HeartbeatTimeout. This change adds support to that.

https://docs.aws.amazon.com/step-functions/latest/dg/concepts-error-handling.html

closes #16084


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Aug 16, 2021

@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@diegotry diegotry changed the title fea(aws-stepfunctions): add support to heartbeat catch feat(aws-stepfunctions): add support to heartbeat catch Aug 16, 2021
@diegotry diegotry changed the title feat(aws-stepfunctions): add support to heartbeat catch fix(aws-stepfunctions): add missing support to heartbeat error Aug 16, 2021
@diegotry diegotry changed the title fix(aws-stepfunctions): add missing support to heartbeat error chore(aws-stepfunctions): add missing support to heartbeat error Aug 16, 2021
@diegotry
Copy link
Contributor Author

I believe this makes sense to be a feat(...). I am going to update the README as there's no documentation around Catch

@diegotry diegotry changed the title chore(aws-stepfunctions): add missing support to heartbeat error feat(aws-stepfunctions): add support to heartbeat error inside catch block Aug 16, 2021
@diegotry diegotry force-pushed the ds/add-heartbeat-support branch 3 times, most recently from 99f27db to f099add Compare August 17, 2021 00:51
@BenChaimberg BenChaimberg self-assigned this Aug 17, 2021
@BenChaimberg BenChaimberg added the @aws-cdk/aws-stepfunctions Related to AWS StepFunctions label Aug 17, 2021
packages/@aws-cdk/aws-stepfunctions/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-stepfunctions/README.md Show resolved Hide resolved
packages/@aws-cdk/aws-stepfunctions/lib/types.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-stepfunctions/test/task-base.test.ts Outdated Show resolved Hide resolved
@BenChaimberg BenChaimberg added the pr-linter/exempt-test The PR linter will not require test changes label Aug 18, 2021
@diegotry diegotry force-pushed the ds/add-heartbeat-support branch from bc1e589 to 3b92169 Compare August 18, 2021 21:30
@mergify mergify bot dismissed BenChaimberg’s stale review August 18, 2021 21:31

Pull request has been modified.

@diegotry diegotry force-pushed the ds/add-heartbeat-support branch from 3b92169 to 290a57e Compare August 18, 2021 21:34
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 290a57e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2372b3c into aws:master Aug 18, 2021
@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

smguggen pushed a commit to smguggen/aws-cdk that referenced this pull request Aug 24, 2021
…block (aws#16078)

Step Functions recently added a feature to catch States.HeartbeatTimeout. This change adds support to that.

https://docs.aws.amazon.com/step-functions/latest/dg/concepts-error-handling.html

closes aws#16084

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
…block (aws#16078)

Step Functions recently added a feature to catch States.HeartbeatTimeout. This change adds support to that.

https://docs.aws.amazon.com/step-functions/latest/dg/concepts-error-handling.html

closes aws#16084

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Sep 6, 2021
…block (aws#16078)

Step Functions recently added a feature to catch States.HeartbeatTimeout. This change adds support to that.

https://docs.aws.amazon.com/step-functions/latest/dg/concepts-error-handling.html

closes aws#16084

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this pull request Sep 7, 2021
…block (aws#16078)

Step Functions recently added a feature to catch States.HeartbeatTimeout. This change adds support to that.

https://docs.aws.amazon.com/step-functions/latest/dg/concepts-error-handling.html

closes aws#16084

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-stepfunctions Related to AWS StepFunctions pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-stepfunctions): Add support to States.HeartbeatTimeout
3 participants