-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apigatewayv2-integrations): full API for API Gateway V2 AWS_PROXY integrations #16287
Closed
Closed
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
c9f7d3b
Getting started with eventbridge integration
alanraison 8bc1f35
Extending HttpIntegration will full set of properties for AWS_PROXY i…
alanraison 420437a
EventBridge-PutEvents and SQS-SendMessage integrations
alanraison b0d80ea
SQS ReceiveMessage integration
alanraison 087f83d
SQS DeleteMessage integration
alanraison 4dcd2d0
SQS-PurgeQueue integration
alanraison 1f35e0c
refactoring test
alanraison 216fd12
formatting
alanraison 06a90b2
Kinesis PutRecord integration
alanraison d92cf9d
Step Functions integrations
alanraison 7637ded
Role is mandatory for all AWS Service integrations
alanraison 69643ea
Fix EventBridge schema
alanraison 39824c6
add permissions
alanraison dea5f56
making role mandatory
alanraison 83fbd9b
Starting to support MappingExpressions
alanraison 3aace30
Adding mapping expressions for more complete integrations
alanraison b4680e5
Mapping Expressions for all AWS integrations
alanraison fbe3fe7
kinesis integration test
alanraison 3da6a9f
Step function tests
alanraison 1a9efab
some documentation
alanraison File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't the integration automatically add the correct permissions to the role?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the review. I thought about that, but since the queue name, for example, could come from the payload, it wouldn't be possible for the cdk to know what permissions may be required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. But we could maybe identify when the queue name is known at synth time and in this case give the right permissions.