feat(elbv2): support ALB target for NLB #16687
Merged
+885
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @njlynch can you take a look? |
RomainMuller
force-pushed
the
master
branch
from
924c117 to
ebfd5f2
Compare
|
Hi @njlynch the CI passed. Can you take a look? |
ryparker
added
@aws-cdk/aws-elasticloadbalancingv2-targets
feature-request
njlynch
reviewed
Oct 7, 2021
packages/@aws-cdk/aws-elasticloadbalancingv2-targets/lib/alb-target.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-elasticloadbalancingv2-targets/lib/alb-target.ts
Outdated
Show resolved
Hide resolved
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
@njlynch CI passed. Are we ready to ship it? |
Yup, I did. Silly mergify dismissed it though. I'll re-ship. |
njlynch
approved these changes
Oct 7, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
njlynch
pushed a commit
that referenced
this pull request
Oct 11, 2021
This PR allows NLB to have a single ALB as the target. Fixes: #16679 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
This PR allows NLB to have a single ALB as the target. Fixes: aws#16679 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows NLB to have a single ALB as the target.
Fixes: #16679
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license