Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(aws-s3): Clarify update is required before setting autoDeleteObjects to false #16828

Merged
merged 1 commit into from
Oct 6, 2021
Merged

docs(aws-s3): Clarify update is required before setting autoDeleteObjects to false #16828

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/@aws-cdk/aws-s3/lib/bucket.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -937,7 +937,7 @@ export interface BucketMetrics {
* Specifies a list of tag filters to use as a metrics configuration filter.
* The metrics configuration includes only objects that meet the filter's criteria.
*/
readonly tagFilters?: {[tag: string]: any};
readonly tagFilters?: { [tag: string]: any };
}

/**
Expand Down Expand Up @@ -1231,8 +1231,8 @@ export interface BucketProps {
*
* **Warning** if you have deployed a bucket with `autoDeleteObjects: true`,
* switching this to `false` in a CDK version *before* `1.126.0` will lead to
* all objects in the bucket being deleted. Be sure to update to version `1.126.0`
* or later before switching this value to `false`.
* all objects in the bucket being deleted. Be sure to update your bucket resources
* by deploying with CDK version `1.126.0` or later **before** switching this value to `false`.
*
* @default false
*/
Expand Down Expand Up @@ -1797,7 +1797,7 @@ export class Bucket extends BucketBase {
}
}

private parseTagFilters(tagFilters?: {[tag: string]: any}) {
private parseTagFilters(tagFilters?: { [tag: string]: any }) {
if (!tagFilters || tagFilters.length === 0) {
return undefined;
}
Expand Down