Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): asset hash is different between linux and windows #16945

Merged
merged 3 commits into from
Oct 13, 2021
Merged

fix(core): asset hash is different between linux and windows #16945

merged 3 commits into from
Oct 13, 2021

Commits on Oct 13, 2021

  1. fix(core): asset hash is different on linux vs windows 

    The hash for a specific file in a directory include its relative path.
This gives different results on Linux vs Windows because of the
different path separator. The solution is to normalize the relative path
using forward slashes.

Affects directory assets with subdirectories.

Closes aws#14555
Closes aws#16928
    @jogold
    jogold committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    3b58e90 View commit details
    Browse the repository at this point in the history

  2. hashComponent

    @jogold
    jogold committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    3516ca3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into hash-rel-path-normalize

    @mergify
    mergify[bot] committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    5eda8e3 View commit details
    Browse the repository at this point in the history