Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoscaling): add timezone property to Scheduled Action #17330

Conversation

eastNine
Copy link
Contributor

@eastNine eastNine commented Nov 4, 2021

Add timezone property to ScheduledAction.

example:

import * as asg from '@aws-cdk/aws-autoscaling';

new asg.ScheduledAction(this, 'test', {
    autoScalingGroup: 'test',
    desiredCapacity: 1,
    minCapacity: 1,
    maxCapacity: 2,
    schedule: {
        expressionString: '0 3 * * *'
    },
    timeZone: 'Asia/Seoul'
});

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 4, 2021

@github-actions github-actions bot added the @aws-cdk/aws-autoscaling Related to Amazon EC2 Auto Scaling label Nov 4, 2021
@rix0rrr rix0rrr changed the title fix(aws-autoscaling): add timezone property to Scheduled Action fix(autoscaling): add timezone property to Scheduled Action Nov 9, 2021
Copy link
Contributor

@comcalvi comcalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: edf191c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 3154a58 into aws:master Nov 9, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Add timezone property to ScheduledAction.

example:
```typescript
import * as asg from '@aws-cdk/aws-autoscaling';

new asg.ScheduledAction(this, 'test', {
    autoScalingGroup: 'test',
    desiredCapacity: 1,
    minCapacity: 1,
    maxCapacity: 2,
    schedule: {
        expressionString: '0 3 * * *'
    },
    timeZone: 'Asia/Seoul'
});
```

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-autoscaling Related to Amazon EC2 Auto Scaling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants