chore: fix list of deprecated APIs so APIs are actually stripped in V2. #17708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change to strip deprecated APIs based on a list was introduced several weeks ago; however, that list was built off of the v1/master branch, not v2. This meant the FQNs of all of the types was wrong, leading to *nothing* being stripped, and all deprecated APIs being re-introduced into the V2 source. This change re-builds the deprecated_apis.txt list so the correct APIs are removed from V2.
|
|
rix0rrr
approved these changes
Nov 25, 2021
|
@Mergifyio backport master |
|
@Mergifyio backport master |
🟠 Waiting for conditions to match
|
1 similar comment
🟠 Waiting for conditions to match
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify bot
pushed a commit
that referenced
this pull request
Nov 25, 2021
…2. (#17708) The change to strip deprecated APIs based on a list was introduced several weeks ago; however, that list was built off of the v1/master branch, not v2. This meant the FQNs of all of the types was wrong, leading to *nothing* being stripped, and all deprecated APIs being re-introduced into the V2 source. This change re-builds the deprecated_apis.txt list so the correct APIs are removed from V2. Also fixed a bug with submodules in the list-deprecated-apis script. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* (cherry picked from commit 28332e3) # Conflicts: # deprecated_apis.txt
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change to strip deprecated APIs based on a list was introduced several weeks
ago; however, that list was built off of the v1/master branch, not v2. This
meant the FQNs of all of the types was wrong, leading to nothing being
stripped, and all deprecated APIs being re-introduced into the V2 source.
This change re-builds the deprecated_apis.txt list so the correct APIs are
removed from V2. Also fixed a bug with submodules in the list-deprecated-apis script.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license